all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Re: send new reply from gnus hangs
Date: Fri, 14 Jun 2019 07:58:34 -0700	[thread overview]
Message-ID: <87muikdxid.fsf@ericabrahamsen.net> (raw)
In-Reply-To: 87sgscqo4r.fsf@telefonica.net

Óscar Fuentes <ofv@wanadoo.es> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Okay, that worked!
>>
>> What does everyone think of the attached diff? It moves the
>> `message-check' call out of the internal function (that seems like work
>> that should be done by the caller, not the internal function, and helps
>> the call fit in visually), and either returns nil or errors depending on
>> an optional arg.
>
> I have no time now to review the code (and I'm not familiar with Gnus'
> code base) but I was going to propose reverting the problematic commit.
> If your patch solves the problem, great. If there are doubts, the right
> thing is reverting.
>
> There is no justification for having master in an unusable state (if you
> are a Gnus user) for more than a week due to a cosmetic change like
> this.

Stefan's already fixed this with a different patch, it should be working
again now.




  reply	other threads:[~2019-06-14 14:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-07 21:20 send new reply from gnus hangs Andy Moreton
2019-06-07 22:34 ` Óscar Fuentes
2019-06-09 22:47   ` Óscar Fuentes
2019-06-09 23:00     ` Óscar Fuentes
2019-06-09 23:03       ` Óscar Fuentes
2019-06-09 23:11         ` Óscar Fuentes
2019-06-09 23:18           ` Óscar Fuentes
2019-06-09 23:19           ` Óscar Fuentes
2019-06-09 23:25             ` Óscar Fuentes
2019-06-09 23:33               ` Óscar Fuentes
2019-06-10  7:56                 ` Robert Pluim
2019-06-10 11:52                 ` Andy Moreton
2019-06-14  2:38                   ` Eric Abrahamsen
2019-06-14  2:39                   ` Eric Abrahamsen
2019-06-14 13:42                     ` Óscar Fuentes
2019-06-14 14:58                       ` Eric Abrahamsen [this message]
2019-06-09 23:04       ` Óscar Fuentes
2019-06-09 23:06       ` Óscar Fuentes
2019-06-09 23:16         ` Óscar Fuentes
2019-06-09 23:02     ` Óscar Fuentes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87muikdxid.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.