From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: Alvaro Ramirez <alvaro@xenodium.com>,
35609@debbugs.gnu.org, Roland Winkler <winkler@gnu.org>
Subject: bug#35609: 26.2; wdired-finish-edit clears find-dired listing
Date: Mon, 15 Jul 2019 19:33:46 +0200 [thread overview]
Message-ID: <87muhfb3t1.fsf@mouse.gnus.org> (raw)
In-Reply-To: <87sgr7tvo5.fsf@gmx.net> (Stephen Berman's message of "Mon, 15 Jul 2019 12:54:34 +0200")
Stephen Berman <stephen.berman@gmx.net> writes:
> - (forward-line)
> - (beginning-of-line)))))
> + (forward-line)))))
>
> (defun wdired-get-previous-link (&optional old move)
>
> These lines are at the end of a while (not (eobp)) loop and, unless I'm
> overlooking something, prior to the change to find-dired-sentinel, the
> use of beginning-of-line here was a noop, since forward-line always puts
> point at BOL -- except when the buffer doesn't end with a newline, and
> that's why the change to find-dired-sentinel caused the find-dired hang.
> Thus, reverting the above three lines of the find-dired-sentinel change
> makes beginning-of-line in wdired-preprocess-symlinks strictly a noop,
> while retaining that change makes calling beginning-of-line harmful, so
> in any case that call should removed. Or does anyone see a problem with
> that?
Yes, I think you're right -- removing that beginning-of-line is the
correct thing, no matter what.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-07-15 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 8:42 bug#35609: 26.2; wdired-finish-edit clears find-dired listing Alvaro Ramirez
2019-07-09 3:03 ` Lars Ingebrigtsen
2019-07-15 10:54 ` Stephen Berman
2019-07-15 17:33 ` Lars Ingebrigtsen [this message]
2019-07-15 18:37 ` Roland Winkler
2019-07-16 9:09 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muhfb3t1.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=35609@debbugs.gnu.org \
--cc=alvaro@xenodium.com \
--cc=stephen.berman@gmx.net \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.