From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: andrewjmoreton@gmail.com, emacs-devel@gnu.org
Subject: Re: [PATCH] Improve Gravatar support
Date: Tue, 23 Jul 2019 09:36:37 +0100 [thread overview]
Message-ID: <87muh56tbe.fsf@tcd.ie> (raw)
In-Reply-To: <83tvbdpjli.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 23 Jul 2019 05:31:37 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Date: Mon, 22 Jul 2019 22:42:27 +0100
>> Cc: emacs-devel@gnu.org
>>
>> Since the first patch only touches existing documentation, it could even
>> be applied to emacs-26. Eli?
>
> Fine with me, but:
>
>> -@pxref{Image Descriptors, ,Image Descriptors, elisp, The Emacs Lisp
>> -Reference Manual} for the valid properties for various image types.
>> -Currently, @code{pbm} is used for X-Face images and @code{png} is used
>> -for Face images in Emacs. Only the @code{:face} property is effective
>> -on the @code{xface} image type in XEmacs if it is built with the
>> +For the valid properties of various image types, @pxref{Image
>> +Descriptors,,, elisp, The Emacs Lisp Reference Manual}. Currently,
>
> This part is better solved by simply replacing @pxref with @xref, and
> adding a comma after the closing brace.
Done and pushed:
Clarify Gravatar docs
086a56ed43 2019-07-23 09:30:39 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=086a56ed43de17015a14a4f1e799d258a789440a
Thanks,
--
Basil
next prev parent reply other threads:[~2019-07-23 8:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 13:23 [PATCH] Improve Gravatar support Basil L. Contovounesios
2019-07-22 13:31 ` Lars Ingebrigtsen
2019-07-22 21:44 ` Basil L. Contovounesios
2019-07-23 11:29 ` Lars Ingebrigtsen
2019-07-22 13:39 ` Andy Moreton
2019-07-22 21:42 ` Basil L. Contovounesios
2019-07-23 2:31 ` Eli Zaretskii
2019-07-23 8:36 ` Basil L. Contovounesios [this message]
2019-07-23 8:36 ` Andy Moreton
2019-07-23 9:18 ` Basil L. Contovounesios
2019-08-02 13:45 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muh56tbe.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=andrewjmoreton@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.