From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Improve Gravatar support Date: Tue, 23 Jul 2019 10:18:10 +0100 Message-ID: <87muh55ctp.fsf@tcd.ie> References: <87muh6w6c6.fsf@tcd.ie> <878ssp6918.fsf@tcd.ie> <864l3di1vj.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="78272"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 23 11:18:32 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpqwK-000KGp-97 for ged-emacs-devel@m.gmane.org; Tue, 23 Jul 2019 11:18:32 +0200 Original-Received: from localhost ([::1]:40518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpqwJ-0000mk-3e for ged-emacs-devel@m.gmane.org; Tue, 23 Jul 2019 05:18:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44120) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpqw3-0000eH-3z for emacs-devel@gnu.org; Tue, 23 Jul 2019 05:18:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpqw2-0003E2-7W for emacs-devel@gnu.org; Tue, 23 Jul 2019 05:18:15 -0400 Original-Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:39693) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpqw2-00039Y-0f for emacs-devel@gnu.org; Tue, 23 Jul 2019 05:18:14 -0400 Original-Received: by mail-wm1-x342.google.com with SMTP id u25so27436536wmc.4 for ; Tue, 23 Jul 2019 02:18:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ts+tWBrdnvCAhOjRajTluhCWMzavgidjE8G9s8NpcBY=; b=ic//w5U5itt7yHUraAn9/Z8ddSPPeXADiLg4Oft7XokYJHWC5VbsDrmLAp8WSA/+pO r0v/vlYwngpN+YsLTcHFkyQJw2wpNwWM8YUhF/+7fNWz5IabFFtx3WJUrsYMqFS0sKAm 7+G8i0UiEc3QOaP0WD4CdXeBN+94htbPvlnHKX/2me0IAtKkcxYPKqOqoMmknKD+UCoM 0cNdQegAhQBU0oZwvByFHgvl55RHi6hF/DbcV4Cc+voBh7B8Bk+XcMkcsLFFm7A4GIlV tPjg6M4KTmr9ME4STdKoGK6xWL8KXJ+8rR+naUHFVnJkvzMmTXMuSBErTeuCFdaQgpI0 WBPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ts+tWBrdnvCAhOjRajTluhCWMzavgidjE8G9s8NpcBY=; b=f1HlTLSy3dLqfIwtWrPjrVVtGFohK+MTjqw8tBjfS/7WLj68Xjh5HILjnmjxB7bcrr MTmu1I11+o1JItQp87mS4f1IfvjVpGE4ElyoV3YJWCm+hByAcq0h3zojjYgzRHlyO+Dr 9XtYwU6+3CIBpw0e8/8e9lo2PsH2Q2e8VCJDM2QBwPLYHyQT7gpbsnLGfeiFq1wukP9B pIvkO3hqFdzA8p3ZVYgQIDbO1esfG+bgcc7/8EGSxV0x3kZ3roaBClc8etw/KrXyoHYS oRoB1X6T4W6O7/XYfEREOHnKQGHVtEk1VTNSt7zUaTX8P+QtmxrNXutfau6YncVf8umI Z9Xg== X-Gm-Message-State: APjAAAXiLbJ3PGr0hyMbV8Un39UQOZPvmnkLh+Q3EI+C+FK8E4NVERu/ Zc42xHnkHUeORlDNJ6Ab6HpSgA== X-Google-Smtp-Source: APXvYqwSrb3rGlMtzqCimT17kxXLqmjCjd0dqx4LozI+9rcMBHOgTdYKKy5Kf5bZZE4MKnFKS/j1ew== X-Received: by 2002:a1c:7310:: with SMTP id d16mr66256025wmb.107.1563873492159; Tue, 23 Jul 2019 02:18:12 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id f1sm29118215wml.28.2019.07.23.02.18.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 23 Jul 2019 02:18:11 -0700 (PDT) In-Reply-To: <864l3di1vj.fsf@gmail.com> (Andy Moreton's message of "Tue, 23 Jul 2019 09:36:16 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238829 Archived-At: Andy Moreton writes: > On Mon 22 Jul 2019, Basil L. Contovounesios wrote: > >> Andy Moreton writes: >> >>> It is better to put each in a separate patch, to ease later bisection if >>> needed. >> >> More often I see reviewers express the opposite feeling here, but since >> I don't personally mind and you asked so nicely: > > Thanks. A series of simple patches is easier to review than a longer > patch that mixes several logical changes, and bisection is more likely > to return a useful answer. Sure, but the preferred granularity is subjective. > The patches look good to me, Thanks, -- Basil