From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 6cfda69 1/2: Add support for dealing with decoded time structures Date: Wed, 31 Jul 2019 22:48:26 +0200 Message-ID: <87mugund5x.fsf@mouse.gnus.org> References: <20190729122247.28663.99759@vcs0.savannah.gnu.org> <20190729122257.00600207F5@vcs0.savannah.gnu.org> <87imriymhk.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="227900"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 31 22:50:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsvXu-000x6O-UR for ged-emacs-devel@m.gmane.org; Wed, 31 Jul 2019 22:50:03 +0200 Original-Received: from localhost ([::1]:44466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsvXt-0005T5-M1 for ged-emacs-devel@m.gmane.org; Wed, 31 Jul 2019 16:50:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35690) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsvWT-0002pK-EG for emacs-devel@gnu.org; Wed, 31 Jul 2019 16:48:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsvWS-0000kJ-BX for emacs-devel@gnu.org; Wed, 31 Jul 2019 16:48:33 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:49800) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hsvWS-0000j0-51 for emacs-devel@gnu.org; Wed, 31 Jul 2019 16:48:32 -0400 Original-Received: from 77.18.62.220.tmi.telenormobil.no ([77.18.62.220] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsvWN-0000Gf-Ka; Wed, 31 Jul 2019 22:48:30 +0200 In-Reply-To: <87imriymhk.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 31 Jul 2019 23:31:35 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239064 Archived-At: "Basil L. Contovounesios" writes: >> +(require 'cl-lib) >> +(require 'subr-x) > > The latter can be wrapped in eval-when-compile, right? Probably... but I think, these days, the likelihood of subr-x not being loaded by something in your Emacs is pretty slim, so I'm not sure it's worth wrapping those in the case where we only use macros from it. >> +(defun date-days-in-month (year month) >> + "The number of days in MONTH in YEAR." >> + (if (= month 2) >> + (if (date-leap-year-p year) >> + 29 >> + 28) >> + (if (memq month '(1 3 5 7 8 10 12)) >> + 31 >> + 30))) > > Doesn't this already exist as the Gregorian calendar-last-day-of-month > in calendar.el? Yes, apparently. (I didn't know about it.) > Out of curiosity, where does the jurisdiction of time-date.el end and > calendar.el begin? Is the former focussed more on internal timestamp > handling, and the latter on the more user-facing (M D Y) format and the > Calendar application? I assumed that it's all about the Calendar application. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no