From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#36588: Unable to revert M-x apropos help buffer Date: Mon, 05 Aug 2019 01:45:53 +0300 Message-ID: <87mugopn1a.fsf@tcd.ie> References: <87h87sk4fv.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="18211"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36588-done@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 05 00:47:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huPHT-0004cO-0j for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Aug 2019 00:47:11 +0200 Original-Received: from localhost ([::1]:49706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huPHR-000480-Cc for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 18:47:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49576) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huPHM-000460-Bh for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 18:47:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huPHL-00059K-7s for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 18:47:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53755) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1huPHK-000593-Sf for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 18:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1huPHK-0001yT-Q5 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 18:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2019 22:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36588 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 36588-done@debbugs.gnu.org id=D36588.15649587717509 (code D ref 36588); Sun, 04 Aug 2019 22:47:02 +0000 Original-Received: (at 36588-done) by debbugs.gnu.org; 4 Aug 2019 22:46:11 +0000 Original-Received: from localhost ([127.0.0.1]:34338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huPGU-0001x2-Mz for submit@debbugs.gnu.org; Sun, 04 Aug 2019 18:46:10 -0400 Original-Received: from mail-wm1-f68.google.com ([209.85.128.68]:39788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huPGS-0001wi-Ey for 36588-done@debbugs.gnu.org; Sun, 04 Aug 2019 18:46:09 -0400 Original-Received: by mail-wm1-f68.google.com with SMTP id u25so60868548wmc.4 for <36588-done@debbugs.gnu.org>; Sun, 04 Aug 2019 15:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+MVdVw9X6aGAU/NZv0OsgzddA9rXgW/edq2jCSArXvU=; b=vog5zqJ6dPFsrfCta4j+tepFhWGhMk3xraC2e5zlwoeC9auZvKDjNn2FXkwLHc/W88 kTz+e48TxecutOMWljIfFyccX7oIkIQQJGUGLDHSwj3Z+jG/PjutVFHZ7Pb8w5TfmhFt CcDeTE3nctRJMYaGeG32fAol/eZvcRQ9svHFq8kpKMiHVqEqIs7LHfrUDVeCKWIcdBah Bs1XfoUEsIROGsTVgNVh78kwNDtFI/Fn/cMle6KQZM9/D4LnhP3mhYJ2adha8phUNBwi M6ecBzUoHh+o5b+zrFmdGnoLvTwTSsOjr8DSlfAa/u8pI5SHaGfEJ04S9iOEstCo//wA etkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+MVdVw9X6aGAU/NZv0OsgzddA9rXgW/edq2jCSArXvU=; b=lUI5MgwQJT6Q1BFOp2udkWZJogD7MyxGuH3O0iMPOhPUmMsDJdc+4vbCby4SNvti8m 8lm71A2Ffv91vWBnq65+Y8eQzhzM5bjmwacW745IJlaYskka9p25G3wzx4q30EVcXpbI tCswo+WnQG+oBt2Jsdw5spX44xnQ9A1/aWtubpRVVoKPj7oAcl3/mqXFj5SDG9joXRtU F7N0e1cQN+ss3VkRR6iEREzE2b7HzU3vkf5rt3IyQJBfBJYZkD2kU64vT8SKyV1xKBN7 1D9FyOHni3XDw5MsQJOm7cNKtBJsHIr3p/YjiKiI4Sr46hZX+cySn+7w/tHVFFmgDG0p F83w== X-Gm-Message-State: APjAAAW5/6Ejjb3vTF0y4xrTw9gSMVOa8P/QZ1RvWsTF12aS2hUanr58 dSBxuT0hkRaNEUh7gnTIGYu1iQ== X-Google-Smtp-Source: APXvYqxyceodqTw+dyEm+I7eiBUW8gpQHa8//UT/z+jzdMl1Aa7IjMOrh4W1X1lZSjIxsgjqB1kGoQ== X-Received: by 2002:a7b:c954:: with SMTP id i20mr15211201wml.169.1564958762446; Sun, 04 Aug 2019 15:46:02 -0700 (PDT) Original-Received: from localhost (adsl-107.91.140.91.tellas.gr. [91.140.91.107]) by smtp.gmail.com with ESMTPSA id t140sm11637305wmt.0.2019.08.04.15.46.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 04 Aug 2019 15:46:01 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Fri, 12 Jul 2019 07:03:31 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164601 Archived-At: tags 36588 fixed close 36588 27.1 quit Stefan Kangas writes: > Not familiar with this code, so I can't speak to your solution. I can confirm > it fixes the problem though. Thanks for looking at it so promptly. Thanks, I've now pushed the patch to master[1] and am therefore closing this report. [1]: Support reverting Apropos buffers (bug#36588) 4cd41ba8de 2019-08-05 01:19:51 +0300 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4cd41ba8def704ce3bd2f3806176815fd696fa57 > I've attached a small patch with a test for this. Thanks, but I'm not sure it's applicable here; see below. > From 562d2622048be8ac5509d8ccd4b9fd18244fc3a4 Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Fri, 12 Jul 2019 06:57:29 +0200 > Subject: [PATCH] * test/lisp/apropos-tests.el: New file. [...] > +(ert-deftest apropos-tests-revert-buffer () > + (with-temp-buffer > + (apropos "foo") > + (revert-buffer nil t) > + (should (looking-at "Type RET on a type label")))) [Nit: Use looking-at-p unless subsequently using the match data.] I don't currently see a clean way to test this behaviour non-interactively, as the apropos command takes over the hard-coded *Apropos* buffer and can pop up new windows and frames (which also renders the call to with-temp-buffer a no-op, AFAICT). This is far too intrusive for the ERT case. Alternatives include refactoring apropos.el to make it more testable, and adding manual tests under test/manual/, but either of these deserves its own bug report. Thanks, -- Basil