From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#36940: tests slowness and failure after recent Tramp changes Date: Sat, 10 Aug 2019 11:43:33 +0200 Message-ID: <87mughfj96.fsf@gmx.de> References: <57e233fe-19e9-6eac-7fd5-7e181879d4df@cs.ucla.edu> <87h86uh2l6.fsf@gmx.de> <1bec46f5-01e7-5ea4-5562-501185d80ecf@cs.ucla.edu> <87v9vaf4sk.fsf@gmx.de> <87r25xf1dn.fsf@gmx.de> <8736ibkbne.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="245131"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36940@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 10 11:44:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hwNuz-0011bo-H2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Aug 2019 11:44:09 +0200 Original-Received: from localhost ([::1]:35578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwNuy-0005fq-Ig for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Aug 2019 05:44:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37164) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwNut-0005ZV-Sc for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 05:44:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hwNus-0006Nx-Oe for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 05:44:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34651) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hwNus-0006N1-Gi for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 05:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hwNus-00077l-Cm for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 05:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Aug 2019 09:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36940 X-GNU-PR-Package: emacs Original-Received: via spool by 36940-submit@debbugs.gnu.org id=B36940.156543024027371 (code B ref 36940); Sat, 10 Aug 2019 09:44:02 +0000 Original-Received: (at 36940) by debbugs.gnu.org; 10 Aug 2019 09:44:00 +0000 Original-Received: from localhost ([127.0.0.1]:43472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwNuq-00077O-0u for submit@debbugs.gnu.org; Sat, 10 Aug 2019 05:44:00 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:41851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwNuo-000779-In for 36940@debbugs.gnu.org; Sat, 10 Aug 2019 05:43:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1565430218; bh=jdESbv/qzi6UDywUTO1Ycbnc+P8TVyJM0bND8gAYgNA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=TCPL/MsxO0pr4NXgdSYSvY2IQvbUMSy6e0Nam/vDINJliT5Mt9RO5d609m/Ry0vpg BLJMw5LIkdD9bOBtHA+A6ZCeBl4m98sCN9wKnLMIxyGn9w5c8eB+O6AzTR2A/p0tGs k+qPwUIVGiOVFfGhC1+WPOMHHmaO3rWjTQIbmM64= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.91.249.250]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Lfppu-1ifvDE0Sss-00pIMo; Sat, 10 Aug 2019 11:43:38 +0200 In-Reply-To: (Paul Eggert's message of "Fri, 9 Aug 2019 18:39:13 -0700") X-Provags-ID: V03:K1:6E4Ja2gYPmsi1yY4sdDyc9+dXE/xvyN+YUI7dKGjyBlbjOlus4h UWcVFtp/sthiM0x8hh4dLbF3yU45qGNQ8e1lttul7pmeVLzlP3bhWLv3BDMAWIYV156FFPE VZGpmSQ3RTluzYKrTP910LXq6/a6XvBPZFhvGRt8R6fDx/RFguVXbogV1iLsAA7V2Y3VQ2A hqp6JiP/Opx6N5kiff4oQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:+hw60PwzGQo=:BNsr1eaOeL/56h8AKNpDl0 6qwDBaI6U7VVa/6ImvYkhvhm+M/jqESPhVllyORFfAeeT+THwEs1A9q/+2tOetNliPl5Pcepr hA8h3vYNWLI0dwh7p51vcL9GmMkl5Oqkp25Ypcw0swtsObg8wkhGnxfcR6Svr6mJKUL9zx2Ds 85nB/uA3tVHw590ncfl7GlIyPz5PRtWi3pfUFyn5rEgT2ZAy0lf5NZuukUWPkL5oq8Xsrucsf z28QcoUFgpQH5rZuiWvNt5FKuU+JAloYRyeo37PtBACUMnzKqQECzQNFyRIz+RtbWIPh0mpDH bkBreCHMIluzqvrlQB06Pn0ndUbIGM/sUaOPEbvTwd0vc2otpiFRFhWOECh0mW6ep5QcXlngU WyVDanXhIiMVWm4kDI1Fb5JFRMFhsqCGuHyvRgq+scQ4AE0d9Xe8xfz3/7AsSAS20CPdEGQPd VipSBhyNCHOn4OGEb/FaGkXDTV+589qT2mfT47ZTjEh4cfJHBKctWdZc4X0qAsI1fC/2/AaOP aaYEjMj6ucMULmB/u74SPX2XLWLYRJwFIQB1btdMU56rHGXXYs18LNg0DPv1IArKI/aSdfvkO FOxfJpxSHIWBOWh7YLcrYWyO97kET+fgskUfFghVODA9RzpL5CEeSvvaYapkg0g8suckci7gb pos7jmOHgJiS2G2591Y8iXT469XsBKj1T+VLQmm1n1NFv2k/+xJKsPEJMhy1ydAcfjN3gxiL5 MYYqRxBJNLq4Rjb2BVZ+BWWklkWwUvHwQ/XIQMCxLyTlz4nZbCw+5ISy4boVqlG9u3g+ehIQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164834 Archived-At: Paul Eggert writes: Hi Paul, > Your patch has several instances of (floor (float-time X)) that would > be slightly better if written as (time-convert X 'integer), as the > former has (unlikely) rounding errors that the latter lacks. > > I assume that the test now uses integer timestamps because file > systems routinely drop low-order parts of timestamps. But won't the > test continue to have problems with filesystems whose timestamp > resolution is 2 seconds? I have heard of such things. Thanks for the explanation. Honestly, we have also a further problem. The tests compare time values taken on different machines. It cannot be assumed that they are always synchronized. Until now it works, but who knows. The tests in tramp--test-file-attributes-equal-p do not require exact time stamps. They just want to ensure, that time values in file attributes are newer than the time the ert test case has started. I've changed the test such a way, that it is compared with the start time minus 60 seconds. This solves the two problems you have mentioned, and it also allows a time offset of up to 60 seconds for the two machines in question. This shall suffice for most of the caes in practice. A more precise test would be to retrieve the ert test start time, as taken from the remote machine. But I don't know of a general function doing this. Best regards, Michael.