From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Date: Wed, 21 Aug 2019 13:18:59 -0700 Message-ID: <87mug2xoek.fsf@mouse.gnus.org> References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="21482"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Christoph Scholtes , 9867@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 21 22:20:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0X5Y-0005T6-MA for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Aug 2019 22:20:12 +0200 Original-Received: from localhost ([::1]:54250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0X5X-0007rz-IU for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Aug 2019 16:20:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60547) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0X5Q-0007py-3s for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2019 16:20:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0X5O-0000su-Tf for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2019 16:20:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55924) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0X5O-0000sg-Q3 for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2019 16:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i0X5O-00087x-K0 for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2019 16:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Aug 2019 20:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156641874931170 (code B ref 9867); Wed, 21 Aug 2019 20:20:02 +0000 Original-Received: (at 9867) by debbugs.gnu.org; 21 Aug 2019 20:19:09 +0000 Original-Received: from localhost ([127.0.0.1]:36512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0X4X-00086f-BI for submit@debbugs.gnu.org; Wed, 21 Aug 2019 16:19:09 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:42730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0X4V-00086X-RD for 9867@debbugs.gnu.org; Wed, 21 Aug 2019 16:19:08 -0400 Original-Received: from 77.16.217.167.tmi.telenormobil.no ([77.16.217.167] helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0X4Q-00069g-7x; Wed, 21 Aug 2019 22:19:05 +0200 In-Reply-To: <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> (martin rudalics's message of "Tue, 20 Aug 2019 10:19:29 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165518 Archived-At: martin rudalics writes: > If people really need such a hook at all, please > > - Make it either an abnormal hook run with the window quit as argument > or run it from 'quit-window' but then only if it quits the selected > window. I was going back and forth on whether to call the hook from `quit-window' or `quit-restore-window', so I ended up with invalid vode in the latter. Thinking about it a bit more, I think it makes more sense to just run it from the former command -- other callers that call `quit-restore-window' should perhaps call that hook manually (or not) at all. I'll move the hook over. > - Fix the reference to the non-existent function 'quit-buffer'. OK; done. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no