From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: PATCH: isearch-yank-until-char Date: Wed, 04 Sep 2019 11:47:20 -0500 Message-ID: <87mufkt3dz.fsf@red-bean.com> References: <87tvakfnv4.fsf@red-bean.com> <87lfvvjxjs.fsf@mail.linkov.net> <87sgq1r9rb.fsf@red-bean.com> <87lfvt6m1e.fsf@mail.linkov.net> <877e7256uc.fsf@red-bean.com> <604cbbef-7e25-486a-a97a-9bc1adf23928@default> <871rx87b9h.fsf@red-bean.com> <77205e15-f38a-46dc-9451-4030a318900a@default> <874l23ak8m.fsf@red-bean.com> <87k1az8vk5.fsf@red-bean.com> <87o90b600w.fsf@red-bean.com> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="96733"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 04 18:48:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i5YSG-000P1G-5U for ged-emacs-devel@m.gmane.org; Wed, 04 Sep 2019 18:48:24 +0200 Original-Received: from localhost ([::1]:35370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5YSE-0002Qm-ER for ged-emacs-devel@m.gmane.org; Wed, 04 Sep 2019 12:48:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44652) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5YRK-0002Qd-M0 for emacs-devel@gnu.org; Wed, 04 Sep 2019 12:47:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5YRJ-0000Pn-F5 for emacs-devel@gnu.org; Wed, 04 Sep 2019 12:47:26 -0400 Original-Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]:46272) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i5YRJ-0000PM-8U for emacs-devel@gnu.org; Wed, 04 Sep 2019 12:47:25 -0400 Original-Received: by mail-io1-xd2b.google.com with SMTP id x4so45577760iog.13 for ; Wed, 04 Sep 2019 09:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version; bh=gEXY8mIAsS1k9mlmXOvw8NqtgjfNMJvgaFU1fk8U5B0=; b=X88DVAibEanAgqA1y+EPigFtSlPWDwAMBLA6Mz2DajI1pzBU2e66wZDIezAogZ+Aeq JnUm6rB58FWLHeNtihu6brVKrvHYlRiyqNck9u2mZ/uMwCmn0/oqZrghbAq6ddqfi4Je XhO2W+0F2AmsugvDxURptNbogkKCbjq9DHkcHwT3W/Hxvcwv6uy3VCo+eQKlyfM/gMtu kXUEvBtM79OkZXG+DWiF7f2AdjKDXQnBY99ag+3hW8yEoycSE9zH8KyNPCL9LaQrKt5L VVxN2Jfg/oXIR2SptVKqnbvTu1jBZw07LVnknYF0AnSUuizU9HHMcgM0xAv+DBvNxuq7 XMsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:references:reply-to:date :in-reply-to:message-id:user-agent:mime-version; bh=gEXY8mIAsS1k9mlmXOvw8NqtgjfNMJvgaFU1fk8U5B0=; b=QHW4eKH5i3neZwJe41ltN+PIq93eYGY3UnPDh2JwuS8SUYmlD3FyXgbGeV13XKbBRH aOWEJt8hUYzgUgZRMLQ4A0d/yPfuUM6NECsZlAQxTp2lQ2EdmFdy/I8nPV7jzaGYU3He zP9grMrL7wHFr+/q1ja2UaRSOsZInKDiCSNGg7cRAobxeRYM9bdPHlsS+Q7px5KHfRz2 qLS5mCT9OI/hTokCtkjtnG+JQOvkAyBRJpai4iWAvejVQAht06KDB9P4fXNsQ9imtDhn futRToCHJD3ABdEv0rKROtCCsFGcdOVSADS5kYEzPYqfpQtxWcYuIqpA/esWZ+d6Kj62 TI0g== X-Gm-Message-State: APjAAAVeKOhd2pL22XdkS4CMIcdUHU7is9Lp9g9Ys+G2aTO5z3gwkUT6 y30S9mlYYE95px1mwj4v/hMniYMe X-Google-Smtp-Source: APXvYqzw7BazIx+nCGkbVkmR2TU+vrMU2OxvE2P/2xJQoNpWu0ck5iPBKlKaxx1pWngcvM38b2wIPg== X-Received: by 2002:a6b:7f07:: with SMTP id l7mr5871180ioq.167.1567615643542; Wed, 04 Sep 2019 09:47:23 -0700 (PDT) Original-Received: from kwork (74-92-190-114-Illinois.hfc.comcastbusiness.net. [74.92.190.114]) by smtp.gmail.com with ESMTPSA id p9sm19199006ios.1.2019.09.04.09.47.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2019 09:47:22 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Mon, 26 Aug 2019 15:43:13 -0700 (PDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d2b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239835 Archived-At: I was about to finally commit the latest patch [1] and realized I wasn't sure whether to commit it on master or on the emacs-26 branch. According to the CONTRIBUTE file (at least as I read it) a change like this should go on master. However, I've been surprised in the past to be informed that a given change should go on the current release branch instead of on master -- I believe that's happened even with non-bugfix-but-still-small changes such as this one. And I saw from Eli's recent post that emacs-26 is open again. So, just checking: I should put this on master, right? By the way, Drew, regarding your point: >Very interesting. That helps, especially the part >about its use in keyboard macros. That use case might >even be worth pointing out in the doc. Thx. I've been pondering whether that would be overly prescriptive or not... It might indeed be worth an extra sentence in the new documentation, and I may adjust the patch accordingly. Best regards, -Karl [1] https://lists.gnu.org/archive/html/emacs-devel/2019-08/msg00522.html