From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Sergey Organov Newsgroups: gmane.emacs.bugs Subject: bug#37916: GNUS: wrong item selected in gnus-thread-hide-subtree customization Date: Fri, 25 Oct 2019 10:13:43 +0300 Message-ID: <87mudp9u1k.fsf@osv.gnss.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="182467"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) To: 37916@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 25 09:34:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNu75-000lN1-NH for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Oct 2019 09:34:24 +0200 Original-Received: from localhost ([::1]:56886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNu73-0001ut-AU for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Oct 2019 03:34:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40040) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNtnP-00008Z-Ob for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 03:14:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNtnO-0005zE-MK for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 03:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56615) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNtnO-0005z3-IN for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 03:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iNtnO-00043u-BW for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 03:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sergey Organov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Oct 2019 07:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37916 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157198763115589 (code B ref -1); Fri, 25 Oct 2019 07:14:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Oct 2019 07:13:51 +0000 Original-Received: from localhost ([127.0.0.1]:37203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNtnD-00043M-5r for submit@debbugs.gnu.org; Fri, 25 Oct 2019 03:13:51 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:54042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNtnB-00043F-Ef for submit@debbugs.gnu.org; Fri, 25 Oct 2019 03:13:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40001) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNtn9-0007xP-Rm for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 03:13:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNtn8-0005qu-NP for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 03:13:47 -0400 Original-Received: from mail.javad.com ([54.86.164.124]:40122) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iNtn8-0005qR-Ef for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 03:13:46 -0400 Original-Received: from osv (unknown [89.175.180.246]) by mail.javad.com (Postfix) with ESMTPSA id 4F8F03EB70 for ; Fri, 25 Oct 2019 07:13:45 +0000 (UTC) Authentication-Results: mail.javad.com; dkim=pass (1024-bit key; unprotected) header.d=javad.com header.i=@javad.com header.b=agy602yK; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=javad.com; s=default; t=1571987625; bh=NpWIZ/5kKDXAPtej2wvTVJ0wi9d2SIPtQ5eI6wl6b3E=; l=1166; h=Received:From:To:Subject; b=agy602yKwKZZ47TjWvD38+rt+XYpxR10si1i68a+cPm4iQuGr1NcUgET4IkSwRgbp mrPCtFnrLQKCzYsdyN13qKoGWjDTjNlpQhm/ZAdFKF3NWfAUA+f+MIFitVryz08fOv xK8Zd8Ynpdriasn23k8eDAwXdohAYJ5s0eJC1YHY= Authentication-Results: ip-172-31-2-110; spf=pass (sender IP is 89.175.180.246) smtp.mailfrom=osv@javad.com smtp.helo=osv Received-SPF: pass (ip-172-31-2-110: connection is authenticated) Original-Received: from osv by osv with local (Exim 4.84_2) (envelope-from ) id 1iNtn5-0000PW-TB for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2019 10:13:43 +0300 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170151 Archived-At: The "Non-nil" defcustom item is selected in customization buffer when actual value of the gnus-thread-hide-subtree is 'nil. -- 8< -- Fix gnus-thread-hide-subtree defcustom * lisp/gnus/gnus-sum.el (gnus-thread-hide-subtree): fix order of items to prevent first 'sexp' from matching 'nil, that caused "Non-nil" item to be selected in customization buffer when actual variable value is 'nil. --- lisp/gnus/gnus-sum.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index b5d7448..1970465 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -332,11 +332,11 @@ This can be a predicate specifier which says which threads to hide. If threads are hidden, you have to run the command `gnus-summary-show-thread' by hand or select an article." :group 'gnus-thread - :type '(radio (sexp :format "Non-nil\n" + :type '(radio (const nil) + (sexp :format "Non-nil\n" :match (lambda (widget value) (not (or (consp value) (functionp value)))) :value t) - (const nil) (sexp :tag "Predicate specifier"))) (defcustom gnus-thread-hide-killed t -- 2.1.4