all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Sergey Organov <sorganov@gmail.com>
To: 37916@debbugs.gnu.org
Subject: bug#37916: GNUS: wrong item selected in gnus-thread-hide-subtree customization
Date: Fri, 25 Oct 2019 10:13:43 +0300	[thread overview]
Message-ID: <87mudp9u1k.fsf@osv.gnss.ru> (raw)


The "Non-nil" defcustom item is selected in customization buffer when
actual value of the gnus-thread-hide-subtree is 'nil.

-- 8< --

Fix gnus-thread-hide-subtree defcustom

* lisp/gnus/gnus-sum.el (gnus-thread-hide-subtree): fix order of
items to prevent first 'sexp' from matching 'nil, that caused
"Non-nil" item to be selected in customization buffer when actual
variable value is 'nil.
---
 lisp/gnus/gnus-sum.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index b5d7448..1970465 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -332,11 +332,11 @@ This can be a predicate specifier which says which threads to hide.
 If threads are hidden, you have to run the command
 `gnus-summary-show-thread' by hand or select an article."
   :group 'gnus-thread
-  :type '(radio (sexp :format "Non-nil\n"
+  :type '(radio (const nil)
+		(sexp :format "Non-nil\n"
 		      :match (lambda (widget value)
 			       (not (or (consp value) (functionp value))))
 		      :value t)
-		(const nil)
 		(sexp :tag "Predicate specifier")))
 
 (defcustom gnus-thread-hide-killed t
-- 
2.1.4





             reply	other threads:[~2019-10-25  7:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25  7:13 Sergey Organov [this message]
2019-10-25 10:39 ` bug#37916: GNUS: wrong item selected in gnus-thread-hide-subtree customization Lars Ingebrigtsen
2019-10-25 13:12   ` Sergey Organov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mudp9u1k.fsf@osv.gnss.ru \
    --to=sorganov@gmail.com \
    --cc=37916@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.