From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#38011: 27.0.50; [PATCH] WIP on allowing Gnus backends to return header data directly Date: Thu, 07 Nov 2019 15:21:21 -0800 Message-ID: <87mud75l3i.fsf@ericabrahamsen.net> References: <87y2x0a9bl.fsf@ericabrahamsen.net> <87a79f3cu3.fsf@gnus.org> <8736f7l9rd.fsf@ericabrahamsen.net> <87eeyqfi4u.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="116504"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 38011@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 08 00:22:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iSr6V-000U7v-4m for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Nov 2019 00:22:15 +0100 Original-Received: from localhost ([::1]:48736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSr6T-0003LE-Dz for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Nov 2019 18:22:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42758) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSr6L-0003L4-L4 for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2019 18:22:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSr6J-0004uh-N1 for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2019 18:22:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35298) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSr6J-0004uV-Jm for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2019 18:22:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iSr6J-0006IR-E1 for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2019 18:22:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Nov 2019 23:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38011 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38011-submit@debbugs.gnu.org id=B38011.157316889024160 (code B ref 38011); Thu, 07 Nov 2019 23:22:01 +0000 Original-Received: (at 38011) by debbugs.gnu.org; 7 Nov 2019 23:21:30 +0000 Original-Received: from localhost ([127.0.0.1]:44119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSr5m-0006Hc-7A for submit@debbugs.gnu.org; Thu, 07 Nov 2019 18:21:30 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:57908 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSr5k-0006HP-A8 for 38011@debbugs.gnu.org; Thu, 07 Nov 2019 18:21:29 -0500 Original-Received: from localhost (unknown [205.175.106.190]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 82E43FA092; Thu, 7 Nov 2019 23:21:22 +0000 (UTC) In-Reply-To: <87eeyqfi4u.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 02 Nov 2019 15:49:21 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171127 Archived-At: I knew this seemed too simple... Andy Cohen pointed out that `gnus-get-newsgroup-headers{,-xover}' were doing more work (running hooks, and the alter function) that needed to also be done if headers were returned directly. There's a bunch of other overlap between those two functions (and between `gnus-get-newsgroup-headers' and `nnheader-parse-naked-head') that Andy is working on refactoring (I hope). In the meantime there are several other places in the code that use `gnus-retrieve-headers', and will need to be updated to handle the possibility that headers have been returned directly. What I'd really like to do, as much as possible, is to switch to `gnus-fetch-headers', so we get our headers back and don't need to know how that happened. This will also avoid ugliness like `nnvirtual-convert-headers'. I think I can probably figure out how to do this in most spots. gnus-agent and gnus-cache are particularly gnarly, though: what does -braid-nov/-braid-heads actually do? Eric