all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] master 7a63b77: Add debbugs-*-tagged commands
Date: Fri, 22 Nov 2019 17:39:14 +0100	[thread overview]
Message-ID: <87mucnoogd.fsf@gmx.de> (raw)
In-Reply-To: <jwvwobtxlws.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 21 Nov 2019 10:58:02 -0500")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>>> +  (cl-letf (((symbol-function 'debbugs-gnu-show-reports)
>>>> +	     #'debbugs-org-show-reports))
>>> Yuck.  If we keep this functionality, it'd be worth introducing some
>>> variable that we can set buffer-locally here instead of having to
>>> let-bind a function like that.
>> We could do, but is it really that bad using letf?
>
> It's like using an advice in your own code, only worse ;-)

I've pushed a fix.

>         Stefan

Best regards, Michael.



      reply	other threads:[~2019-11-22 16:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191121144120.3671.37844@vcs0.savannah.gnu.org>
     [not found] ` <20191121144121.AB3C720C06@vcs0.savannah.gnu.org>
2019-11-21 15:42   ` [elpa] master 7a63b77: Add debbugs-*-tagged commands Stefan Monnier
2019-11-21 15:54     ` Michael Albinus
2019-11-21 15:58       ` Stefan Monnier
2019-11-22 16:39         ` Michael Albinus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mucnoogd.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.