From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.devel Subject: Re: Submitting patches from magit Date: Thu, 19 Dec 2019 23:24:30 +0100 Message-ID: <87mubox8bl.fsf@bernoul.li> References: <87immc5c51.fsf@dick> <87bls459pl.fsf@dick> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="189643"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: Phil Sainty , emacs-devel To: dick.r.chiang@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 19 23:26:53 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ii4Fx-000nBw-5D for ged-emacs-devel@m.gmane.org; Thu, 19 Dec 2019 23:26:53 +0100 Original-Received: from localhost ([::1]:48384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ii4Fv-0001W4-DR for ged-emacs-devel@m.gmane.org; Thu, 19 Dec 2019 17:26:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36945) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ii4Dj-0000EG-O9 for emacs-devel@gnu.org; Thu, 19 Dec 2019 17:24:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ii4Di-0001za-7Z for emacs-devel@gnu.org; Thu, 19 Dec 2019 17:24:35 -0500 Original-Received: from mail.hostpark.net ([212.243.197.30]:42216) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ii4Dh-0001o2-UT for emacs-devel@gnu.org; Thu, 19 Dec 2019 17:24:34 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 89D171667E; Thu, 19 Dec 2019 23:24:31 +0100 (CET) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id wQkpszYsvf5P; Thu, 19 Dec 2019 23:24:31 +0100 (CET) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 1C55616651; Thu, 19 Dec 2019 23:24:31 +0100 (CET) In-reply-to: <87bls459pl.fsf@dick> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 212.243.197.30 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243497 Archived-At: dick.r.chiang@gmail.com writes: >> Assuming this is only useful with Magit installed, would it make more sense >> for it to be contributed to Magit? > > Maybe. The package monkeys a magit menu to seamlessly insert itself, so > embedding within magit would actually *reduce* the lines of code. Instead of the magit-patch-changelog-initialize hack use: (transient-append-suffix 'magit-patch-create "c" '("e" "Create patches for Emacs" magit-patch-changelog-create)) Also don't fiddle with after-init-hook. Just put this at the top-level. > But I suspect Mr. Bernoulli would not want such an emacs-devel-specific task > to be integrated into a fully general git porcelain. Yes, I think this should remain a separate package.