From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#39428: 28.0.50; cl--push-clause-loop-body: eval macro arg just once Date: Tue, 04 Feb 2020 22:05:30 +0100 Message-ID: <87mu9yhxlx.fsf@calancha-pc.dy.bbexcite.jp> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="124975"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan monnier , dick.r.chiang@gmail.com To: 39428@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 04 22:06:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iz5Oj-000WPY-Qz for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Feb 2020 22:06:17 +0100 Original-Received: from localhost ([::1]:38150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz5Og-0002Tq-TH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Feb 2020 16:06:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41513) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz5OX-0002TY-RR for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 16:06:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iz5OV-0004U2-I3 for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 16:06:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38893) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iz5OV-0004Sr-4c for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 16:06:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iz5OU-00042B-3I; Tue, 04 Feb 2020 16:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, dick.r.chiang@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Feb 2020 21:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39428 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: stefan monnier , dick.r.chiang@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.158085034915486 (code B ref -1); Tue, 04 Feb 2020 21:06:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Feb 2020 21:05:49 +0000 Original-Received: from localhost ([127.0.0.1]:44863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz5OG-00041i-Ss for submit@debbugs.gnu.org; Tue, 04 Feb 2020 16:05:49 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:51794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iz5OE-00041Z-U9 for submit@debbugs.gnu.org; Tue, 04 Feb 2020 16:05:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41183) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz5OD-0002Qv-RN for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 16:05:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iz5OC-0002HX-H0 for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 16:05:45 -0500 Original-Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:33767) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iz5OC-0001yk-A1 for bug-gnu-emacs@gnu.org; Tue, 04 Feb 2020 16:05:44 -0500 Original-Received: by mail-wr1-x442.google.com with SMTP id u6so11638182wrt.0 for ; Tue, 04 Feb 2020 13:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=kVRkihzkYKU2yRFMKfZP+ExKIzBY+MYRS13MFZ9WrYU=; b=VYU2pMhE4iXHPBje4p7OgN+GRivfVTopbbchGvWdt47SMQogg0/mZqZi3dFYiGwxB6 d5bDiGo4OHQVD5tEoqQAWF4NSFuQHerszWmBBHD9xZtZN+GE/lrlG5LrmFfacJ5DO4HK PoiQGaQ8sNZu/TvZWoD2408exiUw8BqItO+we4WNqaYOVTH7oDpn4BLtB8Q/S0B0b8VX jLyv40R0QXJsLiKC+ILZdup0SekIuOEp5Zccxt9Gs7J1WohqAJcWc48xH5ea/Sl8exiF s+9oTf4hcJc0gysbDxJSG+oXwigilYqJM9D17kO6Gicg/ex9bDz1sWVL3OcvZkQf5Vie 14ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=kVRkihzkYKU2yRFMKfZP+ExKIzBY+MYRS13MFZ9WrYU=; b=lPqWXMiZOAdiFtyS71hlKGU0slskqrUcvJCr6T6kXctGKtvwiSlL0WfKBB0m+H0JdK Rj2a/yAgMkUh1i+zcDMP3a/P7Q73fV1kRMAboyRHesAc8D7jqubiOwS+YS+GOfx7jV/4 +TgN3N/xLgCjoYk1rnWapiRPddKhqZ2QFIgQnp+8CU3Ff4ma1TEM1hknwP1SqJrrZmzn 8TMOJbhn6l0Y4gJw7t9E9wGqzuunAFYjp5pBTWDbgCf2Jmsq1ip1pGvv0HvJCiTN8tpq M2Cu+cZf2juYf+0Uyb3oX2/p84gYRfQzuujvrkglfHCavDgKwSM+iWL4JOjCTnaPQtaX ECnA== X-Gm-Message-State: APjAAAV/P/itlgRbzF48OO05C2cFQDA5dX9nTXws+PgK2kQAD35+gvul N39BNSk3bMo3B0pykFKlfjujen9et/U= X-Google-Smtp-Source: APXvYqzVvltEUdkV7+3MaUA6CcLk162jScNrBvAJzDT1sz0CtzK3qLFDtBuSNWmqKcYrG1uYyUVYhQ== X-Received: by 2002:a5d:6646:: with SMTP id f6mr14486334wrw.276.1580850341208; Tue, 04 Feb 2020 13:05:41 -0800 (PST) Original-Received: from calancha-pc.dy.bbexcite.jp ([31.7.242.222]) by smtp.gmail.com with ESMTPSA id g21sm5377560wmh.17.2020.02.04.13.05.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2020 13:05:40 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175674 Archived-At: X-Debbugs-Cc: Stefan Monnier ,dick.r.chiang@gmail.com I think this little tweak has sense. WDYT? --8<-----------------------------cut here---------------start------------->8--- commit eb88afb89a8cfb760d89569e74c8ece1d1c446cb Author: Tino Calancha Date: Tue Feb 4 21:52:06 2020 +0100 Eval macro arg just once * lisp/emacs-lisp/cl-macs.el (cl--push-clause-loop-body): Use `macroexp-let2'. diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index 9d0fd15bc3..4c2f58907d 100644 --- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -1037,9 +1037,10 @@ cl-loop (defmacro cl--push-clause-loop-body (clause) "Apply CLAUSE to both `cl--loop-conditions' and `cl--loop-body'." - `(progn - (push ,clause cl--loop-conditions) - (push ,clause cl--loop-body))) + (macroexp-let2 nil sym clause + `(progn + (push ,sym cl--loop-conditions) + (push ,sym cl--loop-body)))) ;; Below is a complete spec for cl-loop, in several parts that correspond ;; to the syntax given in CLtL2. The specs do more than specify where --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 28.0.50 (build 21, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2020-02-04 built on calancha-pc.dy.bbexcite.jp Repository revision: e287da5a8154d83a97107b64915ccc17e3a086b8 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster)