bug#39515: 28.0.50;

bug#39515: 28.0.50;

[Deus Max]

On Mon, 10 Feb 2020, "Jose A. Ortega Ruiz" wrote:

> At any rate, if this is the expected behaviour, one should probably
> update the manual, which doesn't mention this.  That contributes to the
> surprise, at least in my case.

The gnus-group-make-nnir-group (GG) function documentation clearly
states the expected behavior:

    ... if called from the *Group* buffer search any marked groups, or
    the group on the current line, or all the groups under the current
                                     ^^^^^^^^^^^^^^^
    topic.

bug#39515: 28.0.50;

[Eric Abrahamsen]

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]


On 02/13/20 20:06 PM, Deus Max wrote:
> On Mon, 10 Feb 2020, "Jose A. Ortega Ruiz" wrote:
>
>> At any rate, if this is the expected behaviour, one should probably
>> update the manual, which doesn't mention this.  That contributes to the
>> surprise, at least in my case.
>
> The gnus-group-make-nnir-group (GG) function documentation clearly
> states the expected behavior:
>
>     ... if called from the *Group* buffer search any marked groups, or
>     the group on the current line, or all the groups under the current
>                                      ^^^^^^^^^^^^^^^
>     topic.

Good enough for me! This patch should allow us to search all groups,
visible or not, and recursive groups under sub-topics. A quick test
shows it works for me -- anyone else want to try it out first?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-search-topic-groups.diff --]
[-- Type: text/x-patch, Size: 534 bytes --]

diff --git a/lisp/gnus/nnir.el b/lisp/gnus/nnir.el
index 0f364d66e1..0277524a8c 100644
--- a/lisp/gnus/nnir.el
+++ b/lisp/gnus/nnir.el
@@ -617,7 +617,8 @@ gnus-group-make-nnir-group
 		       (list (gnus-group-group-name))
 		     (mapcar (lambda (entry)
 			       (gnus-info-group (cadr entry)))
-			     (gnus-topic-find-groups (gnus-group-topic-name)))))
+			     (gnus-topic-find-groups (gnus-group-topic-name)
+						     nil t nil t))))
 	       gnus-group-server))))
 	 (query-spec
 	  (or (cdr (assq 'nnir-query-spec specs))

bug#39515: 28.0.50;

[Jose A. Ortega Ruiz]

On Thu, Feb 13 2020, Eric Abrahamsen wrote:

[...]

> Good enough for me! This patch should allow us to search all groups,
> visible or not, and recursive groups under sub-topics. A quick test
> shows it works for me -- anyone else want to try it out first?

it's working fine for me too.  thanks both!

bug#39515: 28.0.50;

[Eric Abrahamsen]

On 02/14/20 15:00 PM, Jose A. Ortega Ruiz wrote:
> On Thu, Feb 13 2020, Eric Abrahamsen wrote:
>
> [...]
>
>> Good enough for me! This patch should allow us to search all groups,
>> visible or not, and recursive groups under sub-topics. A quick test
>> shows it works for me -- anyone else want to try it out first?
>
> it's working fine for me too.  thanks both!

Away we go! Closing the bug.

Thanks,
Eric