all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#34891: 25.2; ORG-PUBLISH-FIND-DATE should not use Creation/Publish date (#+DATE:) in file as a modification timestamp.
@ 2019-03-17  5:58 David Trudgett
  2019-05-05  9:29 ` Nicolas Goaziou
  0 siblings, 1 reply; 5+ messages in thread
From: David Trudgett @ 2019-03-17  5:58 UTC (permalink / raw)
  To: 34891

Reproduce:

In an Org mode file, add a #+DATE tag as follows:

#+DATE: First published: 1 February 2014

Then initiate a project publish, which publishes (by default) only
changed files. A date such as the above will not be parsed, so
ox-publish.el will always publish it, even though it has not changed.
Using instead a parsable date format (such as 2014-02-01), this date will be
recognised, and will result in the file never being published, because
it is treating the date as a modification date instead of a creation date.

Desired Behaviour:

ox-publish.el, in function ORG-PUBLISH-FIND-DATE should not be using
this date to detect modifications, as it will never change, and no
modifications will be detected for publishing.

Suggested Fix:

My suggested fix is to always use filesystem timestamp and never use the
#+DATE: line within the Org file.

I.e., change the following lines:

          (cond ((let ((ts (and (consp date) (assq 'timestamp date))))
               (and ts
                (let ((value (org-element-interpret-data ts)))
                  (and (org-string-nw-p value)
                   (org-time-string-to-time value))))))
            ((file-exists-p file)
             (file-attribute-modification-time (file-attributes file)))
            (t (error "No such file: \"%s\"" file)))))))))

to:

          (cond ((file-exists-p file)
             (file-attribute-modification-time (file-attributes file)))
            (t (error "No such file: \"%s\"" file)))))))))

System Info:

In GNU Emacs 25.2.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.21)
  of 2017-09-23, modified by Debian built on lgw01-amd64-050
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description:    Ubuntu 18.04.2 LTS

Configured using:
  'configure --build x86_64-linux-gnu --prefix=/usr
  --sharedstatedir=/var/lib --libexecdir=/usr/lib
  --localstatedir=/var/lib --infodir=/usr/share/info
  --mandir=/usr/share/man --with-pop=yes
  --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.2/site-lisp:/usr/share/emacs/site-lisp
  --with-sound=alsa --without-gconf --build x86_64-linux-gnu
  --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib
  --localstatedir=/var/lib --infodir=/usr/share/info
  --mandir=/usr/share/man --with-pop=yes
  --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.2/site-lisp:/usr/share/emacs/site-lisp
  --with-sound=alsa --without-gconf --with-x=yes --with-x-toolkit=gtk3
  --with-toolkit-scroll-bars 'CFLAGS=-g -O2
  -fdebug-prefix-map=/build/emacs25-jYekUr/emacs25-25.2+1=.
  -fstack-protector-strong -Wformat -Werror=format-security -Wall'
  'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2'
  'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro''

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
   value of $LC_MONETARY: en_AU.UTF-8
   value of $LC_NUMERIC: en_AU.UTF-8
   value of $LC_TIME: en_AU.UTF-8
   value of $LANG: it_IT.UTF-8
   value of $XMODIFIERS: @im=ibus
   locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
   show-paren-mode: t
   TeX-PDF-mode: t
   yas-global-mode: t
   yas-minor-mode: t
   pdf-occur-global-minor-mode: t
   global-magit-file-mode: t
   magit-file-mode: t
   diff-auto-refine-mode: t
   magit-auto-revert-mode: t
   global-git-commit-mode: t
   shell-dirtrack-mode: t
   winner-mode: t
   rxt-global-mode: t
   rxt-mode: t
   beacon-mode: t
   override-global-mode: t
   which-key-mode: t
   helm-mode: t
   async-bytecomp-package-mode: t
   electric-pair-mode: t
   global-auto-complete-mode: t
   auto-complete-mode: t
   paredit-mode: t
   tooltip-mode: t
   global-eldoc-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   column-number-mode: t
   line-number-mode: t
   transient-mark-mode: t

Recent messages:
Resetting customization items...done
Creating customization setup...done
Saving file 
/home/david/TorahBooks/website/src/snippets/2014-02-01_parable-of-the-rich-man-and-the-beggar.org...
Wrote 
/home/david/TorahBooks/website/src/snippets/2014-02-01_parable-of-the-rich-man-and-the-beggar.org
Directory has changed on disk; type g to update Dired
Deleting...done
Quit
Mark saved where search started
Mark set
Mark saved where search started

Load-path shadows:
/home/david/.emacs.d/lisp/paredit hides 
/home/david/.emacs.d/elpa/paredit-24/paredit
/usr/share/emacs/25.2/site-lisp/debian-startup hides 
/usr/share/emacs/site-lisp/debian-startup
/home/david/.emacs.d/elpa/ada-mode-6.0.1/ada-prj hides 
/usr/share/emacs/25.2/lisp/progmodes/ada-prj
/home/david/.emacs.d/elpa/ada-mode-6.0.1/ada-mode hides 
/usr/share/emacs/25.2/lisp/progmodes/ada-mode
/home/david/.emacs.d/elpa/ada-mode-6.0.1/ada-xref hides 
/usr/share/emacs/25.2/lisp/progmodes/ada-xref
/home/david/.emacs.d/elpa/ada-mode-6.0.1/ada-stmt hides 
/usr/share/emacs/25.2/lisp/progmodes/ada-stmt
/home/david/.emacs.d/elpa/org-9.2.2/ox hides 
/usr/share/emacs/25.2/lisp/org/ox
/home/david/.emacs.d/elpa/org-9.2.2/ox-icalendar hides 
/usr/share/emacs/25.2/lisp/org/ox-icalendar
/home/david/.emacs.d/elpa/org-9.2.2/org-macro hides 
/usr/share/emacs/25.2/lisp/org/org-macro
/home/david/.emacs.d/elpa/org-9.2.2/ob-lisp hides 
/usr/share/emacs/25.2/lisp/org/ob-lisp
/home/david/.emacs.d/elpa/org-9.2.2/org-gnus hides 
/usr/share/emacs/25.2/lisp/org/org-gnus
/home/david/.emacs.d/elpa/org-9.2.2/ob-python hides 
/usr/share/emacs/25.2/lisp/org/ob-python
/home/david/.emacs.d/elpa/org-9.2.2/org-footnote hides 
/usr/share/emacs/25.2/lisp/org/org-footnote
/home/david/.emacs.d/elpa/org-9.2.2/org-crypt hides 
/usr/share/emacs/25.2/lisp/org/org-crypt
/home/david/.emacs.d/elpa/org-9.2.2/org-info hides 
/usr/share/emacs/25.2/lisp/org/org-info
/home/david/.emacs.d/elpa/org-9.2.2/org-eshell hides 
/usr/share/emacs/25.2/lisp/org/org-eshell
/home/david/.emacs.d/elpa/org-9.2.2/ob-dot hides 
/usr/share/emacs/25.2/lisp/org/ob-dot
/home/david/.emacs.d/elpa/org-9.2.2/org-attach hides 
/usr/share/emacs/25.2/lisp/org/org-attach
/home/david/.emacs.d/elpa/org-9.2.2/ob-comint hides 
/usr/share/emacs/25.2/lisp/org/ob-comint
/home/david/.emacs.d/elpa/org-9.2.2/ob-screen hides 
/usr/share/emacs/25.2/lisp/org/ob-screen
/home/david/.emacs.d/elpa/org-9.2.2/ob-org hides 
/usr/share/emacs/25.2/lisp/org/ob-org
/home/david/.emacs.d/elpa/org-9.2.2/ob-latex hides 
/usr/share/emacs/25.2/lisp/org/ob-latex
/home/david/.emacs.d/elpa/org-9.2.2/org-timer hides 
/usr/share/emacs/25.2/lisp/org/org-timer
/home/david/.emacs.d/elpa/org-9.2.2/ob-clojure hides 
/usr/share/emacs/25.2/lisp/org/ob-clojure
/home/david/.emacs.d/elpa/org-9.2.2/org hides 
/usr/share/emacs/25.2/lisp/org/org
/home/david/.emacs.d/elpa/org-9.2.2/ob-plantuml hides 
/usr/share/emacs/25.2/lisp/org/ob-plantuml
/home/david/.emacs.d/elpa/org-9.2.2/org-agenda hides 
/usr/share/emacs/25.2/lisp/org/org-agenda
/home/david/.emacs.d/elpa/org-9.2.2/ob-java hides 
/usr/share/emacs/25.2/lisp/org/ob-java
/home/david/.emacs.d/elpa/org-9.2.2/ob-fortran hides 
/usr/share/emacs/25.2/lisp/org/ob-fortran
/home/david/.emacs.d/elpa/org-9.2.2/org-list hides 
/usr/share/emacs/25.2/lisp/org/org-list
/home/david/.emacs.d/elpa/org-9.2.2/ob-scheme hides 
/usr/share/emacs/25.2/lisp/org/ob-scheme
/home/david/.emacs.d/elpa/org-9.2.2/ox-odt hides 
/usr/share/emacs/25.2/lisp/org/ox-odt
/home/david/.emacs.d/elpa/org-9.2.2/ob hides 
/usr/share/emacs/25.2/lisp/org/ob
/home/david/.emacs.d/elpa/org-9.2.2/ob-haskell hides 
/usr/share/emacs/25.2/lisp/org/ob-haskell
/home/david/.emacs.d/elpa/org-9.2.2/ob-R hides 
/usr/share/emacs/25.2/lisp/org/ob-R
/home/david/.emacs.d/elpa/org-9.2.2/org-capture hides 
/usr/share/emacs/25.2/lisp/org/org-capture
/home/david/.emacs.d/elpa/org-9.2.2/ob-table hides 
/usr/share/emacs/25.2/lisp/org/ob-table
/home/david/.emacs.d/elpa/org-9.2.2/ox-md hides 
/usr/share/emacs/25.2/lisp/org/ox-md
/home/david/.emacs.d/elpa/org-9.2.2/ob-ruby hides 
/usr/share/emacs/25.2/lisp/org/ob-ruby
/home/david/.emacs.d/elpa/org-9.2.2/ob-sqlite hides 
/usr/share/emacs/25.2/lisp/org/ob-sqlite
/home/david/.emacs.d/elpa/org-9.2.2/ob-eval hides 
/usr/share/emacs/25.2/lisp/org/ob-eval
/home/david/.emacs.d/elpa/org-9.2.2/ob-picolisp hides 
/usr/share/emacs/25.2/lisp/org/ob-picolisp
/home/david/.emacs.d/elpa/org-9.2.2/ob-sql hides 
/usr/share/emacs/25.2/lisp/org/ob-sql
/home/david/.emacs.d/elpa/org-9.2.2/ob-tangle hides 
/usr/share/emacs/25.2/lisp/org/ob-tangle
/home/david/.emacs.d/elpa/org-9.2.2/ob-C hides 
/usr/share/emacs/25.2/lisp/org/ob-C
/home/david/.emacs.d/elpa/org-9.2.2/ob-octave hides 
/usr/share/emacs/25.2/lisp/org/ob-octave
/home/david/.emacs.d/elpa/org-9.2.2/org-compat hides 
/usr/share/emacs/25.2/lisp/org/org-compat
/home/david/.emacs.d/elpa/org-9.2.2/ob-matlab hides 
/usr/share/emacs/25.2/lisp/org/ob-matlab
/home/david/.emacs.d/elpa/org-9.2.2/org-protocol hides 
/usr/share/emacs/25.2/lisp/org/org-protocol
/home/david/.emacs.d/elpa/org-9.2.2/ob-gnuplot hides 
/usr/share/emacs/25.2/lisp/org/ob-gnuplot
/home/david/.emacs.d/elpa/org-9.2.2/ox-org hides 
/usr/share/emacs/25.2/lisp/org/ox-org
/home/david/.emacs.d/elpa/org-9.2.2/ox-ascii hides 
/usr/share/emacs/25.2/lisp/org/ox-ascii
/home/david/.emacs.d/elpa/org-9.2.2/org-mobile hides 
/usr/share/emacs/25.2/lisp/org/org-mobile
/home/david/.emacs.d/elpa/org-9.2.2/ox-html hides 
/usr/share/emacs/25.2/lisp/org/ox-html
/home/david/.emacs.d/elpa/org-9.2.2/ob-shen hides 
/usr/share/emacs/25.2/lisp/org/ob-shen
/home/david/.emacs.d/elpa/org-9.2.2/org-loaddefs hides 
/usr/share/emacs/25.2/lisp/org/org-loaddefs
/home/david/.emacs.d/elpa/org-9.2.2/ob-awk hides 
/usr/share/emacs/25.2/lisp/org/ob-awk
/home/david/.emacs.d/elpa/org-9.2.2/ob-maxima hides 
/usr/share/emacs/25.2/lisp/org/ob-maxima
/home/david/.emacs.d/elpa/org-9.2.2/org-inlinetask hides 
/usr/share/emacs/25.2/lisp/org/org-inlinetask
/home/david/.emacs.d/elpa/org-9.2.2/ob-ledger hides 
/usr/share/emacs/25.2/lisp/org/ob-ledger
/home/david/.emacs.d/elpa/org-9.2.2/org-faces hides 
/usr/share/emacs/25.2/lisp/org/org-faces
/home/david/.emacs.d/elpa/org-9.2.2/org-mouse hides 
/usr/share/emacs/25.2/lisp/org/org-mouse
/home/david/.emacs.d/elpa/org-9.2.2/org-entities hides 
/usr/share/emacs/25.2/lisp/org/org-entities
/home/david/.emacs.d/elpa/org-9.2.2/org-element hides 
/usr/share/emacs/25.2/lisp/org/org-element
/home/david/.emacs.d/elpa/org-9.2.2/org-macs hides 
/usr/share/emacs/25.2/lisp/org/org-macs
/home/david/.emacs.d/elpa/org-9.2.2/org-id hides 
/usr/share/emacs/25.2/lisp/org/org-id
/home/david/.emacs.d/elpa/org-9.2.2/org-bbdb hides 
/usr/share/emacs/25.2/lisp/org/org-bbdb
/home/david/.emacs.d/elpa/org-9.2.2/org-indent hides 
/usr/share/emacs/25.2/lisp/org/org-indent
/home/david/.emacs.d/elpa/org-9.2.2/ob-emacs-lisp hides 
/usr/share/emacs/25.2/lisp/org/ob-emacs-lisp
/home/david/.emacs.d/elpa/org-9.2.2/ox-latex hides 
/usr/share/emacs/25.2/lisp/org/ox-latex
/home/david/.emacs.d/elpa/org-9.2.2/ob-io hides 
/usr/share/emacs/25.2/lisp/org/ob-io
/home/david/.emacs.d/elpa/org-9.2.2/org-archive hides 
/usr/share/emacs/25.2/lisp/org/org-archive
/home/david/.emacs.d/elpa/org-9.2.2/ob-perl hides 
/usr/share/emacs/25.2/lisp/org/ob-perl
/home/david/.emacs.d/elpa/org-9.2.2/ob-mscgen hides 
/usr/share/emacs/25.2/lisp/org/ob-mscgen
/home/david/.emacs.d/elpa/org-9.2.2/org-irc hides 
/usr/share/emacs/25.2/lisp/org/org-irc
/home/david/.emacs.d/elpa/org-9.2.2/org-bibtex hides 
/usr/share/emacs/25.2/lisp/org/org-bibtex
/home/david/.emacs.d/elpa/org-9.2.2/ob-calc hides 
/usr/share/emacs/25.2/lisp/org/ob-calc
/home/david/.emacs.d/elpa/org-9.2.2/ox-publish hides 
/usr/share/emacs/25.2/lisp/org/ox-publish
/home/david/.emacs.d/elpa/org-9.2.2/ob-asymptote hides 
/usr/share/emacs/25.2/lisp/org/ob-asymptote
/home/david/.emacs.d/elpa/org-9.2.2/ob-makefile hides 
/usr/share/emacs/25.2/lisp/org/ob-makefile
/home/david/.emacs.d/elpa/org-9.2.2/org-src hides 
/usr/share/emacs/25.2/lisp/org/org-src
/home/david/.emacs.d/elpa/org-9.2.2/org-install hides 
/usr/share/emacs/25.2/lisp/org/org-install
/home/david/.emacs.d/elpa/org-9.2.2/org-clock hides 
/usr/share/emacs/25.2/lisp/org/org-clock
/home/david/.emacs.d/elpa/org-9.2.2/org-rmail hides 
/usr/share/emacs/25.2/lisp/org/org-rmail
/home/david/.emacs.d/elpa/org-9.2.2/org-datetree hides 
/usr/share/emacs/25.2/lisp/org/org-datetree
/home/david/.emacs.d/elpa/org-9.2.2/ob-js hides 
/usr/share/emacs/25.2/lisp/org/ob-js
/home/david/.emacs.d/elpa/org-9.2.2/ox-beamer hides 
/usr/share/emacs/25.2/lisp/org/ox-beamer
/home/david/.emacs.d/elpa/org-9.2.2/ob-css hides 
/usr/share/emacs/25.2/lisp/org/ob-css
/home/david/.emacs.d/elpa/org-9.2.2/org-colview hides 
/usr/share/emacs/25.2/lisp/org/org-colview
/home/david/.emacs.d/elpa/org-9.2.2/ob-sass hides 
/usr/share/emacs/25.2/lisp/org/ob-sass
/home/david/.emacs.d/elpa/org-9.2.2/ob-ditaa hides 
/usr/share/emacs/25.2/lisp/org/ob-ditaa
/home/david/.emacs.d/elpa/org-9.2.2/org-mhe hides 
/usr/share/emacs/25.2/lisp/org/org-mhe
/home/david/.emacs.d/elpa/org-9.2.2/org-w3m hides 
/usr/share/emacs/25.2/lisp/org/org-w3m
/home/david/.emacs.d/elpa/org-9.2.2/org-pcomplete hides 
/usr/share/emacs/25.2/lisp/org/org-pcomplete
/home/david/.emacs.d/elpa/org-9.2.2/org-plot hides 
/usr/share/emacs/25.2/lisp/org/org-plot
/home/david/.emacs.d/elpa/org-9.2.2/ob-lilypond hides 
/usr/share/emacs/25.2/lisp/org/ob-lilypond
/home/david/.emacs.d/elpa/org-9.2.2/ob-lob hides 
/usr/share/emacs/25.2/lisp/org/ob-lob
/home/david/.emacs.d/elpa/org-9.2.2/org-feed hides 
/usr/share/emacs/25.2/lisp/org/org-feed
/home/david/.emacs.d/elpa/org-9.2.2/org-habit hides 
/usr/share/emacs/25.2/lisp/org/org-habit
/home/david/.emacs.d/elpa/org-9.2.2/ob-core hides 
/usr/share/emacs/25.2/lisp/org/ob-core
/home/david/.emacs.d/elpa/org-9.2.2/ox-texinfo hides 
/usr/share/emacs/25.2/lisp/org/ox-texinfo
/home/david/.emacs.d/elpa/org-9.2.2/ox-man hides 
/usr/share/emacs/25.2/lisp/org/ox-man
/home/david/.emacs.d/elpa/org-9.2.2/org-version hides 
/usr/share/emacs/25.2/lisp/org/org-version
/home/david/.emacs.d/elpa/org-9.2.2/ob-ocaml hides 
/usr/share/emacs/25.2/lisp/org/ob-ocaml
/home/david/.emacs.d/elpa/org-9.2.2/ob-ref hides 
/usr/share/emacs/25.2/lisp/org/ob-ref
/home/david/.emacs.d/elpa/org-9.2.2/org-docview hides 
/usr/share/emacs/25.2/lisp/org/org-docview
/home/david/.emacs.d/elpa/org-9.2.2/ob-keys hides 
/usr/share/emacs/25.2/lisp/org/ob-keys
/home/david/.emacs.d/elpa/org-9.2.2/org-table hides 
/usr/share/emacs/25.2/lisp/org/org-table
/home/david/.emacs.d/elpa/org-9.2.2/org-ctags hides 
/usr/share/emacs/25.2/lisp/org/org-ctags
/home/david/.emacs.d/elpa/org-9.2.2/ob-exp hides 
/usr/share/emacs/25.2/lisp/org/ob-exp
/home/david/.emacs.d/elpa/seq-2.20/seq hides 
/usr/share/emacs/25.2/lisp/emacs-lisp/seq
/home/david/.emacs.d/elpa/let-alist-1.0.5/let-alist hides 
/usr/share/emacs/25.2/lisp/emacs-lisp/let-alist

Features:
(shadow sort mail-extr emacsbug sendmail ox-texinfo ox-md ox-man
ox-beamer org-protocol org-mouse org-mobile org-feed org-crypt
org-capture org-timer org-table org-colview org-attach org-id
org-archive bug-reference pdf-sync pdf-annot pdf-outline pdf-links
pdf-history preview prv-emacs tex-buf font-latex tex-mode latexenc
image-dired dired-x ffap derived wdired org-jira-sdk ls-lisp org-clock s
jiralib request soap-client warnings autoload lisp-mnt tar-mode
mm-archive url-handlers network-stream nsm starttls url-cache image-file
paren helm-command helm-elisp helm-eval edebug helm-info tramp
tramp-compat tramp-loaddefs trampver ucs-normalize two-column iso-transl
html5-schema nxml-uchnm rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid
nxml-mode nxml-outln nxml-rap nxml-glyph org-agenda ox-org sgml-mode ido
org-indent org-eww org-rmail org-mhe org-irc org-info org-gnus nnir
gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail
mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range
gnus-win gnus gnus-ems nnheader org-docview doc-view org-bibtex bibtex
org-bbdb org-w3m misearch multi-isearch dired-aux vc-git
deeper-blue-theme org-bullets ox-odt rng-loc rng-uri rng-parse rng-match
rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util
ox-latex ox-icalendar ox-html table ox-ascii ox-publish ox latex
tex-ispell tex-style tex dbus xml smart-mode-line-powerline-theme
powerline powerline-separators color powerline-themes smart-mode-line
rich-minority yasnippet flycheck subr-x flymake pdf-occur ibuf-ext
ibuffer tablist tablist-filter semantic/wisent/comp semantic/wisent
semantic/wisent/wisent semantic/util-modes semantic/util semantic
semantic/tag cedet pdf-isearch pdf-misc pdf-tools cus-edit cus-start
cus-load wid-edit pdf-view magit-bookmark bookmark jka-compr pdf-cache
pdf-info tq pdf-util image-mode magit-submodule magit-obsolete
magit-blame magit-stash magit-bisect magit-push magit-pull magit-fetch
magit-clone magit-remote magit-commit magit-sequence magit-notes
magit-worktree magit-tag magit-merge magit-branch magit-reset
magit-collab ghub-graphql treepy graphql ghub url-http tls gnutls url-gw
url-auth let-alist json map magit-files magit-refs magit-status magit
magit-repos magit-apply magit-wip magit-log which-func magit-diff
smerge-mode diff-mode magit-core magit-autorevert autorevert filenotify
magit-process magit-margin magit-mode git-commit magit-git magit-section
magit-utils magit-popup crm log-edit message dired rfc822 mml mml-sec
epg mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log
with-editor shell server dash winner pcre2el rxt re-builder rx beacon
use-package-bind-key bind-key ace-window avy which-key try url url-proxy
url-privacy url-expand url-methods url-history url-cookie url-domsuf
url-util url-parse auth-source gnus-util mm-util help-fns mail-prsvr
password-cache url-vars mailcap auto-complete-config helm-mode
helm-files helm-buffers helm-tags helm-locate helm-grep helm-regexp
helm-utils helm-help helm-types helm helm-source eieio-compat
helm-multi-match helm-lib helm-config helm-easymenu async-bytecomp async
arduino-mode cc-langs cl cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs ada-imenu ada-skel
ada-skeletons skeleton ada-compiler ada-gnat-compile gpr-query gnat-core
ada-mode-compat ada-wisi wisi-process-parse ada-indent-user-options
ada-fix-error ada-lalr-elisp wisi-elisp-parse wisi-compile wisi
wisi-fringe wisi-elisp-lexer wisi-parse-common semantic/lex semantic/fw
mode-local ada-build ada-mode find-file align imenu elec-pair ac-slime
auto-complete popup paredit edmacro kmacro slime compile etags xref
project eieio eieio-core arc-mode archive-mode pp hyperspec thingatpt
browse-url cl-macs use-package-ensure use-package-core org-element
cl-seq avl-tree org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro
org-footnote org-src ob-comint ob-keys org-pcomplete pcomplete comint
ansi-color ring org-list org-faces org-entities time-date noutline
outline easy-mmode org-version ob-emacs-lisp ob-core ob-eval org-compat
advice org-macs org-loaddefs format-spec find-func cal-menu calendar
cal-loaddefs finder-inf tex-site slime-autoloads info package epg-config
seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv
cl-loaddefs pcase cl-lib mule-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan
thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese charscript
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind inotify
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 1480273 148352)
  (symbols 48 72742 0)
  (miscs 40 4010 2130)
  (strings 32 260753 32476)
  (string-bytes 1 8504838)
  (vectors 16 116390)
  (vector-slots 8 2382398 118984)
  (floats 8 1310 1047)
  (intervals 56 78460 5861)
  (buffers 976 158))

-- 

David K. Trudgett
IT Systems and Software Engineer
Ph: 0467 312 782 (mobile) [intl: +61 467 312 782]
Email: David.Trudgett@eclecticse.com.au
Web: http://www.eclecticse.com.au/ (blog)
LinkedIn: https://au.linkedin.com/in/david-trudgett-6191ba103
ABN: 87 984 125 899








^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#34891: 25.2; ORG-PUBLISH-FIND-DATE should not use Creation/Publish date (#+DATE:) in file as a modification timestamp.
  2019-03-17  5:58 bug#34891: 25.2; ORG-PUBLISH-FIND-DATE should not use Creation/Publish date (#+DATE:) in file as a modification timestamp David Trudgett
@ 2019-05-05  9:29 ` Nicolas Goaziou
  2020-05-24  8:22   ` Bastien
  0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2019-05-05  9:29 UTC (permalink / raw)
  To: David Trudgett; +Cc: 34891

Hello,

David Trudgett <david.trudgett@eclecticse.com.au> writes:

> Reproduce:
>
> In an Org mode file, add a #+DATE tag as follows:
>
> #+DATE: First published: 1 February 2014
>
> Then initiate a project publish, which publishes (by default) only
> changed files. A date such as the above will not be parsed, so
> ox-publish.el will always publish it, even though it has not changed.
> Using instead a parsable date format (such as 2014-02-01), this date will be
> recognised, and will result in the file never being published, because
> it is treating the date as a modification date instead of a creation date.
>
> Desired Behaviour:
>
> ox-publish.el, in function ORG-PUBLISH-FIND-DATE should not be using
> this date to detect modifications, as it will never change, and no
> modifications will be detected for publishing.

I don't understand how you come to this conclusion. 

The function responsible for deciding if a file should be published is
`org-publish-cache-file-needs-publishing'. It doesn't call
`org-publish-find-date', but `org-publish-cache-ctime-of-src'. The
latter only uses `file-attribute-modification-time'.

IOW, I think the file is published because you modified since last
publishing.

WDYT?

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#34891: 25.2; ORG-PUBLISH-FIND-DATE should not use Creation/Publish date (#+DATE:) in file as a modification timestamp.
  2019-05-05  9:29 ` Nicolas Goaziou
@ 2020-05-24  8:22   ` Bastien
  0 siblings, 0 replies; 5+ messages in thread
From: Bastien @ 2020-05-24  8:22 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: David Trudgett, 34891-done

Hi David,

after Nicolas' answer, I don't see the bug in here, so I am closing
this bug report.

If you think there is still something wrong, please test with latest
Org and report it again on emacs-orgmode@gnu.org.

Thanks,

-- 
 Bastien




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: bug#34891: 25.2; ORG-PUBLISH-FIND-DATE should not use Creation/Publish date (#+DATE:) in file as a modification timestamp.
@ 2020-05-24 20:46 David Trudgett
  2020-05-25 10:27 ` Bastien
  0 siblings, 1 reply; 5+ messages in thread
From: David Trudgett @ 2020-05-24 20:46 UTC (permalink / raw)
  To: emacs-orgmode

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Thank you, Nicolas and Bastien,

Apologies for the late reply.

The publishing functionality now appears to be working as it should. I
haven't changed anything myself, except to update Org. It's possible I
misdiagnosed the cause of the problem.

In any case, should the issue arise again, I will take another look at
it and let you all know.

Thanks for your attention on this one. It's really appreciated!

Kind regards,
David

- -- 
Key fingerprint: 1365 2C8F F9F1 188D C064 FB60 9F79 BB01 EEBF 48E6

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEs/RVZpgrZ1SbH+KGVnbxJ50cKpEFAl7K3RsACgkQVnbxJ50c
KpGIqQ/9FG/AHuo/H74OiMXbCsuUvAbsKo0HpmWP+pK1gDksx4WJ9fbRLd0nUzM6
xeDXo6dBBcFOYkt9u5HyOjC9Xq4x5z4leg6WuC18bGT9uTHVCIfwAyyMR+tAxwvG
kfJdSvfWs4UV3vMTYTotzXQ6DU3hILdUOYSuYIUJBctx2NsN1KKAZNlmb69PTuog
rdq8OBnA2dcYird62bSwPOOuwb8RnFBwqXNZ76O1a3eS5bTWx+TaLxSwFx3FGfzF
9zrFzNv6qMjw+TbAQxJ5kuNooF2l+xJTpszxGg/WZlaQ32S4kH7/vCKeHitoCFAX
z0ZsJevY9QkK2R4I9i3B6l2AAiMqfEICLouNIpQDhxgHB4w1aFlhi2mIUrtzQ7m+
n8SuUVbxYne4IAW7riF63YfHRbGqTWHZeIQ3YH62jcKIze8rhU+UW/1fVTUilVWh
JESIyQMOwZQ1BUVKPhBKrOpa0auxMhHGOj8chh9LBk2v4aj2rwNkwfTfA0GP0yzk
fdhvgUDgad5G6iovWcYi94ZR2oea43EpS6xih+n/hPSmZ7I2HsUP/ibaH7Jscu+F
sSwAohtAJ84l5SIC28LxHlqM/29ZWO21ZrfrXo0/eDX4hhTgKJLsGVtD8mnlXs8z
5SrYsGi/km8GAATmIWv6QfJ1v6jniUMnPks+3PJl9u8A8A1EQDs=
=/F3t
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: bug#34891: 25.2; ORG-PUBLISH-FIND-DATE should not use Creation/Publish date (#+DATE:) in file as a modification timestamp.
  2020-05-24 20:46 David Trudgett
@ 2020-05-25 10:27 ` Bastien
  0 siblings, 0 replies; 5+ messages in thread
From: Bastien @ 2020-05-25 10:27 UTC (permalink / raw)
  To: David Trudgett; +Cc: emacs-orgmode

Hi David,

David Trudgett <David.Trudgett@eclecticse.com.au> writes:

> The publishing functionality now appears to be working as it
> should. 

Thanks for confirming!

-- 
 Bastien


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-05-25 10:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-17  5:58 bug#34891: 25.2; ORG-PUBLISH-FIND-DATE should not use Creation/Publish date (#+DATE:) in file as a modification timestamp David Trudgett
2019-05-05  9:29 ` Nicolas Goaziou
2020-05-24  8:22   ` Bastien
  -- strict thread matches above, loose matches on Subject: below --
2020-05-24 20:46 David Trudgett
2020-05-25 10:27 ` Bastien

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.