bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation.

[Jonas Bernoulli <jonas@bernoul.li>]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Jonas Bernoulli <jonas@bernoul.li>
>> Date: Thu, 16 Jul 2020 16:54:48 +0200
>> Cc: jonas@bernoul.li
>> 
>> ---
>>  lisp/emacs-lisp/eldoc.el | 14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> When you fix indentation, make sure to use our .dir-locals.el
> settings, to produce canonical whitespace.  In this case, we use only
> spaces in Lisp files, not TABs and spaces.

Gladly!  In fact while I was just taking a bath, I was drafting
a message in my head explaining why such a file should be added!

The reason that I was not aware that the local value is explicitly set
now, is (aside from simply not having checked) that the indentation in
Emacs is so inconsistent that I did occur to me that it might be set
after all.

I did just dig a bit and found bug#20323.  So it turns out we did
eventually set the variable, but we did not adjust existing code to
conform to that setting.

I do care a lot about consistency so I did in fact look at the
surrounding code to determine what style to use.  It was not an easy
decision in this case because both styles are being within this one
function!  I went with tabs because more existing lines did that. ;D

I'll change that before pushing obviously.  And since this commit is
already about *fixing* whitespace, I will also *adjust* the remaining
lines to use the preferred style.

It might be time to revisit the decision to not fix indentation in
bulk.  Since version Git 2.23 "git blame" can ignore the effect and
presence of certain commits.  We could make the whitespace change in
one huge commit and then ignore that commit using the Git variable
"blame.ignoreRevsFile".

> P.S. Why do you CC yourself on every message?  It causes the Reply to
> name you twice, so you will get 2 copies of them.  Is this what you
> want?

Hmmm.  Because that's not the behavior I experience.  Without that
explicit CC I get the message zero times (git send-email does not put
them into the local maildir and debbugs does not appear to be echoing my
own messages back to me).  With that CC I get the messages exactly once.
Maybe you experience something else because debbugs sends *all* message
to you, not just your own?