all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: contovob@tcd.ie, 34476@debbugs.gnu.org, jidanni@jidanni.org
Subject: bug#34476: fluffy whitespace in the mode-line, despite it running off the screen
Date: Fri, 07 Aug 2020 14:15:21 +0200	[thread overview]
Message-ID: <87mu367iue.fsf@gnus.org> (raw)
In-Reply-To: <83y2mq7jk7.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 07 Aug 2020 14:59:52 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> > And it formats the mode-line twice: once in format-mode-line, then
>> > again in display_string, right?
>> 
>> No, display_string just displays the string, I think?
>
> Which is a non-trivial amount of work: loading all the font glyphs
> again and accounting for their metrics, considering the faces, etc.
> All of which was already done.

I'm not very familiar with that code, but from my reading of it, none of
that has been done at this point.

I call Fformat_mode_line (format, Qnil, Qnil, Qnil); instead of
display_mode_element.  Fformat_mode_line sets

  mode_line_target = MODE_LINE_STRING;

or the like, and then calls display_mode_element, which then won't call
display_string at all, but just put all the computed elements in a list.

So nothing is displayed until that call to display_string, in my reading
of the code.

OK, I've now done some more testing -- I removed my call to
display_string, and no mode line is displayed at all, which kinda
supports my reading of the code?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-08-07 12:15 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 13:34 bug#34476: fluffy whitespace in the mode-line, despite it running off the screen 積丹尼 Dan Jacobson
2019-07-09 16:43 ` Lars Ingebrigtsen
2019-07-09 20:46   ` Basil L. Contovounesios
2019-07-09 21:44     ` Lars Ingebrigtsen
2020-08-07  8:00       ` Lars Ingebrigtsen
2020-08-07  8:31         ` Lars Ingebrigtsen
2020-08-07 11:32           ` Eli Zaretskii
2020-08-07 11:41             ` Lars Ingebrigtsen
2020-08-07 11:59               ` Eli Zaretskii
2020-08-07 12:15                 ` Lars Ingebrigtsen [this message]
2020-08-07 13:52                   ` Eli Zaretskii
2020-08-08  9:11                     ` Lars Ingebrigtsen
2020-08-08  9:48                       ` Eli Zaretskii
2020-08-08 10:01                         ` Eli Zaretskii
2020-08-08 11:18                           ` Lars Ingebrigtsen
2020-08-08 12:55                             ` Eli Zaretskii
2020-08-08 14:16                               ` Lars Ingebrigtsen
2020-08-08 15:00                                 ` Eli Zaretskii
2020-08-09  9:56                                   ` Lars Ingebrigtsen
2020-08-09 14:07                                     ` Eli Zaretskii
2020-08-10 14:46                                       ` Eli Zaretskii
2020-08-10 14:56                                         ` Lars Ingebrigtsen
2020-08-14 10:46                                         ` Eli Zaretskii
2020-08-14 12:00                                           ` Lars Ingebrigtsen
2020-08-14 13:16                                             ` Eli Zaretskii
2020-08-15  8:47                                           ` Eli Zaretskii
2020-08-15 10:55                                             ` Lars Ingebrigtsen
2020-08-15 15:12                                               ` Eli Zaretskii
2020-08-16 11:21                                                 ` Lars Ingebrigtsen
2020-08-16 14:43                                                   ` Eli Zaretskii
2020-08-17  8:33                                                     ` Lars Ingebrigtsen
2020-08-17 14:17                                                       ` Eli Zaretskii
2020-12-29  3:54                                                         ` Lars Ingebrigtsen
2020-12-29 15:02                                                           ` Eli Zaretskii
2020-12-29 15:07                                                             ` Lars Ingebrigtsen
2020-12-29 15:54                                                               ` Eli Zaretskii
2020-12-29 17:04                                                                 ` martin rudalics
2020-12-30  2:36                                                                   ` Lars Ingebrigtsen
2020-08-08 11:18                         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu367iue.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=34476@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=eliz@gnu.org \
    --cc=jidanni@jidanni.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.