From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#14645: Keep highlighting face foreground Date: Thu, 13 Aug 2020 13:35:13 +0200 Message-ID: <87mu2ydbim.fsf@gnus.org> References: <87ehc0mjhy.fsf@mail.jurta.org> <87mwqn9g6g.fsf@mail.jurta.org> <87sj0dzoad.fsf@mail.jurta.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1298"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 14645@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 13 13:36:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6BWk-0000CJ-Em for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Aug 2020 13:36:10 +0200 Original-Received: from localhost ([::1]:56664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6BWj-00068H-Gl for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Aug 2020 07:36:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6BWc-000682-Rk for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 07:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6BWc-0005z4-Ib for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 07:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6BWc-0003TC-Gn for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 07:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Aug 2020 11:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14645 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14645-submit@debbugs.gnu.org id=B14645.159731852513275 (code B ref 14645); Thu, 13 Aug 2020 11:36:02 +0000 Original-Received: (at 14645) by debbugs.gnu.org; 13 Aug 2020 11:35:25 +0000 Original-Received: from localhost ([127.0.0.1]:47247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6BW1-0003S3-56 for submit@debbugs.gnu.org; Thu, 13 Aug 2020 07:35:25 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:56702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6BVz-0003Rp-HW for 14645@debbugs.gnu.org; Thu, 13 Aug 2020 07:35:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aBB/A4dlZPE+wH2v2h/Qp0TGw7s+u6mAkF3qyZwxWGI=; b=unQRyxY2RX0NwHzZYT3DGCw3f3 TuRc1cSegXSfHg761958evBXJVZy+KsXfJfky22WjGe3UKhAmQF6bWN2NNQlcpDXSeMWJnpjPhXsY dENs9KdYSRP3G3YJ5HA9sNTKqyaQxbBZJCJOiGcIzGYCF113gud8YvSoCkYwXliNaaOk=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6BVq-0005ct-Pi; Thu, 13 Aug 2020 13:35:17 +0200 In-Reply-To: <87sj0dzoad.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 20 Jun 2013 02:14:18 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185007 Archived-At: Juri Linkov writes: > I was going to propose a similar change to use `add-face-text-property' > in hi-lock, but it turned out to be much simpler because hi-lock > is based on font-lock that already has `font-lock-prepend-text-property' > that does the same: > > === modified file 'lisp/hi-lock.el' > --- lisp/hi-lock.el 2013-06-03 08:51:50 +0000 > +++ lisp/hi-lock.el 2013-06-19 23:12:05 +0000 > @@ -715,7 +690,7 @@ (defun hi-lock-set-pattern (regexp face) > "Highlight REGEXP with face FACE." > ;; Hashcons the regexp, so it can be passed to remove-overlays later. > (setq regexp (hi-lock--hashcons regexp)) > - (let ((pattern (list regexp (list 0 (list 'quote face) t)))) > + (let ((pattern (list regexp (list 0 (list 'quote face) 'prepend)))) If I'm reading this correctly, something similar has been added in the intervening years: (let ((pattern (list (lambda (limit) (let ((case-fold-search case-fold) (search-spaces-regexp spaces-regexp)) (re-search-forward regexp limit t))) (list subexp (list 'quote face) 'prepend))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no