From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Date: Fri, 04 Sep 2020 07:47:24 -0700 Message-ID: <87mu25wqdf.fsf@iris.silentflame.com> References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3401"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43120@debbugs.gnu.org, joaotavora@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 04 16:48:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kED0c-0000k0-HN for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 16:48:11 +0200 Original-Received: from localhost ([::1]:51690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kED0b-0003vp-FW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 10:48:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kED0U-0003tg-7Q for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 10:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57012) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kED0T-0006BU-UA for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 10:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kED0T-0006EV-Sw for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 10:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Sep 2020 14:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43120 X-GNU-PR-Package: emacs Original-Received: via spool by 43120-submit@debbugs.gnu.org id=B43120.159923085523928 (code B ref 43120); Fri, 04 Sep 2020 14:48:01 +0000 Original-Received: (at 43120) by debbugs.gnu.org; 4 Sep 2020 14:47:35 +0000 Original-Received: from localhost ([127.0.0.1]:40325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kED03-0006Ds-Bb for submit@debbugs.gnu.org; Fri, 04 Sep 2020 10:47:35 -0400 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:42359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kED01-0006Df-FX for 43120@debbugs.gnu.org; Fri, 04 Sep 2020 10:47:34 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 7468D90A; Fri, 4 Sep 2020 10:47:26 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 04 Sep 2020 10:47:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=t5051p7LuEG/Ke9T9iCR8OTugR DJF3lDCljNSFfUDBg=; b=ZwqRtDRYqKhZkILciI9AKy+PPObavs4Iv03jGnqp8K PNvXp7WK8uonoIHLPu91l58OU2R7DRRGXqWXV92yAsQ2PdJW5+CxpMQsLlWTufls ahb6MBflHEZXSe/ZIqW/fG9wNMMDpjaSdfVzmm6k22EQ7KMjtnRFyNxm5lTxi997 SS9Uqxd3HEdO4dFGNbelSbGdvKf1vHwCeQpvvkBXMkVrODzFutEzHDEZSvsKJane 05ytdervuMPuKj+SIYxYheNBjcDrBqAl368HbNupgRKgf22ayjIqbSg+bikZ3OSE 8wSK/4nLTu6s6mbl7lI/hXg86+2bhgfSgomNO74aD+pQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=t5051p 7LuEG/Ke9T9iCR8OTugRDJF3lDCljNSFfUDBg=; b=dw8ILBzf6VvsyZLvA56/SQ Ku0x5Vus6TvqIYK5d+6fkTkqqUteOEcqPH73JoU+PVISzcJyzM82QTtOfNG2q5Ya Awun6U5udL55PY5drZrtDN0JoMyex6RCuI8/mktdpZIEuAeYDdTB/NMxNuC1yIlI FbTJIF6+HwPp2gI0hjU9R6ebL1iVTNiRJKmuLqmhpSTg7PMGbpkLb3v4jyPv4khW 7FW1sxVg/gdYzrYdgH1c8zqBV52Ww/knUqYMmXlTVJso8wWq0FKbBSIZIwyniHT+ n+gC1WSWB5qyOFFHlb/khvg99yQI6TYZrFbTKvLOGJKntA3pDibCum48K8FziCeA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudegfedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepufgvrghnucgh hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeegtddvheegfffhffdvfeefhffgjefflefhteevffffkeetgfdt jedtiedvtdevheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: In-Reply-To: <87eenifcgr.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187146 Archived-At: Hello Lars, On Fri 04 Sep 2020 at 05:27AM +02, Lars Ingebrigtsen wrote: > Sean Whitton writes: > >> Unfortunately it does not, so I guess icomplete-fido-exit is not exiting >> the minibuffer through that path. > > Hm. Am I misreading the code here? So the else branch definitely calls > exit-minibuffer... > > (defun icomplete-fido-exit (force) > [...] > (if (and (not force) minibuffer--require-match) > (minibuffer-complete-and-exit) > (exit-minibuffer))) > > And the "then" branch ends up here: > > (defun minibuffer-complete-and-exit () > [...] > (completion-complete-and-exit (minibuffer-prompt-end) (point-max) > #'exit-minibuffer)) > > Hm... which then calls completion--complete-and-exit, which should then > end up calling the exit function in... hm. Perhaps not all the > branches? There's a bunch of callbacks, but I thought I followed them > all to the end and they all ended up calling the exit function, but > perhaps not? Would it be possible for you to edebug through > completion-complete-and-exit? I think I see what the problem is. I was doing the following to generate a test case: C-h f comp [wait for completions to appear] C-g This leaves completion-content-when-empty populated to interfere with the next run, as getting out of the minibuffer that way does not clear the variable, but it should. Might it work to set the variable buffer-local to the minibuffer? Then we can be sure it would always be cleared. -- Sean Whitton