From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#25678: 25.1; defcustom type `(file :must-match t)' seems not to work Date: Thu, 10 Sep 2020 15:13:10 +0200 Message-ID: <87mu1x7p21.fsf@gnus.org> References: <77a3abe9-258c-4863-a87d-2f236babafe4@default> <87pn78s0e6.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13703"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: dieter@duenenhof-wilhelm.de, 25678@debbugs.gnu.org, Noam Postavsky , tim@tim-landscheidt.de To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 10 15:14:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGMOu-0003UF-T5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 15:14:08 +0200 Original-Received: from localhost ([::1]:53614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGMOt-0003Wr-Vs for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 09:14:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGMOo-0003Wj-UZ for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 09:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54302) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGMOo-0005v3-Ly for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 09:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGMOo-0006Ud-Gw for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 09:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Sep 2020 13:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25678 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 25678-submit@debbugs.gnu.org id=B25678.159974360424905 (code B ref 25678); Thu, 10 Sep 2020 13:14:02 +0000 Original-Received: (at 25678) by debbugs.gnu.org; 10 Sep 2020 13:13:24 +0000 Original-Received: from localhost ([127.0.0.1]:37615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGMOC-0006Td-BA for submit@debbugs.gnu.org; Thu, 10 Sep 2020 09:13:24 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:38352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGMOA-0006TM-I8 for 25678@debbugs.gnu.org; Thu, 10 Sep 2020 09:13:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Uc3x+y/ZQpoeD8kB3XCvCcvx3XmHoARWFAWWN3HNdIk=; b=PpL2wAhZp6+T9nwTOGfaLzaCEa H6wW8D/boXEVsy7TWBnyca3pEioVlCrTJez3ypaf32vlpyt4e1ibQNemPNKbRHWe4EAzcVN/DlDqQ 8DGCz6Dy/u4zFsCScmOQbwhY7oE6Y3eDW+USXw0BBk0CNW4r6glzbygScMp46XJ5EYkk=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGMO0-0006ju-1A; Thu, 10 Sep 2020 15:13:14 +0200 X-Now-Playing: Various's _Disco Rallado_: "Jason Forrest - Song For My Grandmother" In-Reply-To: (Mauro Aranda's message of "Wed, 9 Sep 2020 14:21:11 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187728 Archived-At: Mauro Aranda writes: > I found that the :match function will return false positives when > :must-match is nil and value is not a string. This can happen is > the defcustom is of type: > :type '(choice file (const nil))), and the value is nil, because we > check if nil matches with the widget file first. > > Here's a patch to fix it. Thanks; applied to the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no