From: Lars Ingebrigtsen <larsi@gnus.org>
To: Amin Bandali <bandali@gnu.org>
Cc: Corwin Brust <corwin@bru.st>,
emacs-erc@gnu.org, 44100@debbugs.gnu.org,
Olivier Certner <ocert.dev@free.fr>
Subject: bug#44100: Patch
Date: Sun, 01 Nov 2020 14:09:54 +0100 [thread overview]
Message-ID: <87mu01cjfh.fsf__22645.4371631675$1604236352$gmane$org@gnus.org> (raw)
In-Reply-To: <875z6pu8h5.fsf@gnu.org> (Amin Bandali's message of "Sat, 31 Oct 2020 22:16:54 -0400")
Amin Bandali <bandali@gnu.org> writes:
> However, I came up with a potentially more proper different fix: I think
> the presence of the dotted pair with a non-nil cdr is the main problem,
> since it means `erc-modified-channels-alist' does not fully adhere to
> the documented structure in its docstring. So I addressed the issue in
> `erc-track-modified-channels' by wrapping up single faces in lists too,
> ensuring that `erc-modified-channels-alist' never ends in a non-nil cdr.
>
> Something along the lines of the following patch. Thoughts?
[...]
> (when erc-face
> (put-text-property 0 (length channame) 'face erc-face channame)
> - (when (eq erc-face 'erc-default-face)
> + (when (eq (car erc-face) 'erc-default-face)
> (add-face-text-property 0 (length channame) 'bold t channame)))
> channame)
Normalising to having a list of faces here sounds like a good idea, if
I'm skimming the code correctly, but it would probably help
comprehension a bit here if you renamed the parameter from `erc-face' to
something like `face-list'.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-11-01 13:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 16:39 bug#44100: 26.3; ERC: Make IBuffer custom display work again Olivier Certner
2020-10-21 10:08 ` bug#44100: Patch Olivier Certner
2020-10-21 15:54 ` Corwin Brust
[not found] ` <CAJf-WoRBf-TNXSopiUnugOgAj_GAnJsRjkbuwBXRc-m4EB7-Jw@mail.gmail.com>
2020-10-31 19:54 ` Amin Bandali
[not found] ` <87imaquq6z.fsf@gnu.org>
2020-11-01 2:16 ` Amin Bandali
[not found] ` <875z6pu8h5.fsf@gnu.org>
2020-11-01 13:09 ` Lars Ingebrigtsen [this message]
[not found] ` <87mu01cjfh.fsf@gnus.org>
2020-11-03 2:38 ` Amin Bandali
[not found] ` <87lffjf9lu.fsf@gnu.org>
2020-11-05 16:38 ` Olivier Certner
2020-11-07 14:54 ` Amin Bandali
2021-06-04 10:07 ` bug#44100: 26.3; ERC: Make IBuffer custom display work again Lars Ingebrigtsen
[not found] ` <87v96ux7rc.fsf_-_@gnus.org>
2021-06-04 19:58 ` bandali
[not found] ` <1946874.pO33bOzxCm@ravel>
2021-08-03 2:52 ` Amin Bandali
2021-07-06 12:06 ` bug#44100: Updated patch Olivier Certner
2021-07-06 14:29 ` bug#44100: On Amin's proposed change Olivier Certner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87mu01cjfh.fsf__22645.4371631675$1604236352$gmane$org@gnus.org' \
--to=larsi@gnus.org \
--cc=44100@debbugs.gnu.org \
--cc=bandali@gnu.org \
--cc=corwin@bru.st \
--cc=emacs-erc@gnu.org \
--cc=ocert.dev@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.