From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Phil Sainty" <psainty@orcon.net.nz>
Cc: 15696@debbugs.gnu.org
Subject: bug#15696: 24.3; vc-git-annotate-command -- ambiguous short commit hashes cause failures
Date: Sun, 06 Dec 2020 16:17:52 +0100 [thread overview]
Message-ID: <87mtyr9d5r.fsf@gnus.org> (raw)
In-Reply-To: <60659.202.78.240.7.1382567791.squirrel@mail.orcon.net.nz> (Phil Sainty's message of "Thu, 24 Oct 2013 11:36:31 +1300 (NZDT)")
"Phil Sainty" <psainty@orcon.net.nz> writes:
> `vc-git-annotate-command' looks like this:
>
> (defun vc-git-annotate-command (file buf &optional rev)
> (let ((name (file-relative-name file)))
> (vc-git-command buf 'async nil "blame" "--date=iso" "-C" "-C" rev "--"
> name)))
>
> By default, git blame produces short commit hashes. You need to pass
> the -l argument to make it produce full hashes.
>
> This is a problem if the short hash is ambiguous, as none of the
> vc-annotate commands for interacting with that commit work.
>
> Example errors for ambiguous commit hash 7b10edf8:
(This bug report unfortunately got no response at the time.)
The command in question now produces an 11-char short hash, which I
think is pretty rarely ambiguous, in my experience, so I don't think
there's anything more to fix here, and I'm closing this bug report.
If there's still a problem here, please respond to the debbugs address
and we'll reopen.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-12-06 15:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 22:36 bug#15696: 24.3; vc-git-annotate-command -- ambiguous short commit hashes cause failures Phil Sainty
2020-12-06 15:17 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtyr9d5r.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=15696@debbugs.gnu.org \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.