From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45178: buffer-hash docstring should explain difference to secure-hash Date: Fri, 11 Dec 2020 17:00:45 +0100 Message-ID: <87mtyk8h8y.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5306"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45178@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 11 17:05:50 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1knkvW-0001FW-7y for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Dec 2020 17:05:50 +0100 Original-Received: from localhost ([::1]:56866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knkvV-0005We-8K for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Dec 2020 11:05:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knkqt-0001p2-HH for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 11:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59417) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knkqr-00024m-Op for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 11:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1knkqr-0002mw-NV for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 11:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Dec 2020 16:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45178 X-GNU-PR-Package: emacs Original-Received: via spool by 45178-submit@debbugs.gnu.org id=B45178.160770245810702 (code B ref 45178); Fri, 11 Dec 2020 16:01:01 +0000 Original-Received: (at 45178) by debbugs.gnu.org; 11 Dec 2020 16:00:58 +0000 Original-Received: from localhost ([127.0.0.1]:42730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knkqo-0002mY-Iv for submit@debbugs.gnu.org; Fri, 11 Dec 2020 11:00:58 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:35632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knkqm-0002mE-4H for 45178@debbugs.gnu.org; Fri, 11 Dec 2020 11:00:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SaU7HtTiW6xNi7ZfkQ9WbtCHjXONi76sQxKKpK8L8DM=; b=OV3TIc6HIdSQFFCFSPrcj/lGp3 e3N8Qo1LRwRgZMNsVcEuoo6EtyGZt7So2vPma70/gDrKphweopGeI3hb0xHtjo4gh8C23EyUEeSWD f3N7jP0JkrOLp5N9cFU4AAw9J7u+ZRsMfV2SlCZL/CwtA+1yk4+Aj9tmtF1tOX0spH3g=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1knkqd-0004KK-1s; Fri, 11 Dec 2020 17:00:49 +0100 X-Now-Playing: How Strange (feat. Matanza's _How Strange_: "Acoustic Version)" In-Reply-To: (Stefan Kangas's message of "Fri, 11 Dec 2020 08:41:20 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195781 Archived-At: Stefan Kangas writes: > Severity: minor > > It is not clear to me when I would want to use: > > (buffer-hash (current-buffer)) > > instead of > > (secure-hash 'sha1 (current-buffer)) > > One obvious difference is that secure-hash respects narrowing, while > buffer-hash doesn't. I thought the buffer-hash doc string made the use case pretty clear: ---- This function is useful for comparing two buffers running in the same Emacs, but is not guaranteed to return the same hash between different Emacs versions. ---- The only use case for the function is to compare two buffers in the same running Emacs image. It shouldn't be used for anything else. > First, I think we should add something about this to the docstring of > `buffer-hash'. Perhaps we should also mention it in the `secure-hash' > docstring. I think that would be pointing people in the wrong direction. `secure-hash' is the right thing to use in 99% of the cases. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no