From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#11995: vc-compilation-mode name and implementation Date: Wed, 20 Jan 2021 05:20:37 +0100 Message-ID: <87mtx4tf1m.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6543"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 11995@debbugs.gnu.org To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 20 05:21:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l24za-0001dV-Cv for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Jan 2021 05:21:14 +0100 Original-Received: from localhost ([::1]:53560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l24zY-000092-Ur for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jan 2021 23:21:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l24zO-00008M-PJ for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 23:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l24zO-0006VC-HE for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 23:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l24zO-0003GJ-CZ for bug-gnu-emacs@gnu.org; Tue, 19 Jan 2021 23:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Jan 2021 04:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11995 X-GNU-PR-Package: emacs Original-Received: via spool by 11995-submit@debbugs.gnu.org id=B11995.161111645712490 (code B ref 11995); Wed, 20 Jan 2021 04:21:02 +0000 Original-Received: (at 11995) by debbugs.gnu.org; 20 Jan 2021 04:20:57 +0000 Original-Received: from localhost ([127.0.0.1]:52471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l24zJ-0003FO-1N for submit@debbugs.gnu.org; Tue, 19 Jan 2021 23:20:57 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:40168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l24zG-0003F7-Gc for 11995@debbugs.gnu.org; Tue, 19 Jan 2021 23:20:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cTTIw/c0hFFOe78AxM12iPJfbP3KfMk18qhy9y7VvNI=; b=Pzwys8ZmHB+kwrsT3z6ai6yJWy CgEgUfmauoLIs0huDZWG1tTrEb/zmpCUk1H84N2Wngk3KlcFmN6PnYKvaGWMGbxgy/nHM9VVbdtSY BkodXSdylzjymTMIuVEEcoRSJERjPEppMQNcD8latWm8OpdHa6I/9A4Cbl9M3kK5QhVg=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l24z0-0000iv-VK; Wed, 20 Jan 2021 05:20:48 +0100 X-Now-Playing: Joe Jackson's _Live 1980-86 (1)_: "Don't Wanna Be Like That" In-Reply-To: (Dan Nicolaescu's message of "Thu, 19 Jul 2012 15:38:23 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198240 Archived-At: Dan Nicolaescu writes: > The newly added vc-compilation-mode function does not have the best > name, -mode functions stand for modes, this is not one. (I'm going through old bug reports that unfortunately got no response at the time.) It is perhaps not an ideal name, but it's probably too late to change now, though. > Currently the preferred way to define modes is to use > `defined-derived-mode'... > > Also the implementation seems to be a bit more complicated than needed: > there > > Defining a vc-default-compilation-mode function should simplify the > implementation. vc-make-backend-sym is something that very few things > need to call. I think it looks like something was left out of this message? I'm not sure what this is referring to. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no