From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43265: 28.0.50; Inconsistent fontifying in elisp-mode Date: Fri, 22 Jan 2021 20:32:38 +0100 Message-ID: <87mtx0ydgp.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26199"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43265@debbugs.gnu.org, Stefan Monnier To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 22 20:33:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l32BN-0006iX-UC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Jan 2021 20:33:21 +0100 Original-Received: from localhost ([::1]:39816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l32BM-0006l3-IV for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Jan 2021 14:33:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l32B4-0006kq-KA for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2021 14:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49825) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l32B3-000563-Ro for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2021 14:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l32B3-0003Mr-OA for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2021 14:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jan 2021 19:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43265 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 43265-submit@debbugs.gnu.org id=B43265.161134397512933 (code B ref 43265); Fri, 22 Jan 2021 19:33:01 +0000 Original-Received: (at 43265) by debbugs.gnu.org; 22 Jan 2021 19:32:55 +0000 Original-Received: from localhost ([127.0.0.1]:33138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l32Aw-0003MX-Le for submit@debbugs.gnu.org; Fri, 22 Jan 2021 14:32:54 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:44658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l32Au-0003MI-FT for 43265@debbugs.gnu.org; Fri, 22 Jan 2021 14:32:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MaECA5+XJs01IBuOboooAlWkuh79hOEgpenQzEKe9w4=; b=YvXyD2XfO82TV1QSvKFzCf9y2T VF7gnOTtvLmIA9vUJuOpfxTBvZEBNuJ2CcidET1C6mdTutCWYEKYJV6o2OWvBrwb9GDIDAQvjjBZD w0SyPdhQzHs7ffmPksrxuyF8d/vU+oqcWxsO8qxLAfFab7fO+iKejosj2Tv8G2KsMFQk=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l32Ai-0004gI-2u; Fri, 22 Jan 2021 20:32:44 +0100 X-Now-Playing: Various's _Deathbomb Digital Singles Club Year 2_: "Coccooned" In-Reply-To: (Mauro Aranda's message of "Mon, 7 Sep 2020 17:05:01 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198397 Archived-At: Mauro Aranda writes: > To reproduce: > > emacs -Q > In the scratch buffer type: > > (condition-case nil > (fail-badly) > (error (when foo t))) > > I don't see WHEN with font-lock-keyword-face. However: > > (condition-case nil > (fail-badly) > (error (if foo t))) > > IF has font-lock-keyword-face. This is the bit that determines whether to give something a keyword-face: (defun lisp--el-match-keyword (limit) ;; FIXME: Move to elisp-mode.el. (catch 'found (while (re-search-forward (eval-when-compile (concat "(\\(" lisp-mode-symbol-regexp "\\)\\_>")) limit t) (let ((sym (intern-soft (match-string 1)))) (when (or (special-form-p sym) (and (macrop sym) (not (get sym 'no-font-lock-keyword)) (not (lisp--el-non-funcall-position-p (match-beginning 0))))) (throw 'found t)))))) All special forms get it (`if' is a special form), but macros (like `when') only gets it if we're in a funcall position: (defun lisp--el-non-funcall-position-p (pos) "Heuristically determine whether POS is an evaluated position." [...] (and (eq parent 'condition-case) (progn (forward-sexp 2) (< (point) pos)))))))))) And this doesn't count any of the error clauses as being in a funcall position, so no macros in those get a keyword-face. I think. I've added Stefan M to the CCs. If that's the correct analysis, then fixing this shouldn't be too hard, I think? Just add some extra code in the `condition-case' bit to catch this case? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no