From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Patch to avoid flicker in Isearch with lazy count Date: Sat, 30 Jan 2021 20:50:14 +0200 Organization: LINKOV.NET Message-ID: <87mtwqp8d5.fsf@mail.linkov.net> References: <87r1m6jsk7.fsf@gmail.com> <87lfce2ruh.fsf@mail.linkov.net> <87tur1bjof.fsf@gmail.com> <871re5e809.fsf@mail.linkov.net> <87tuqzzl7m.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35502"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 30 19:54:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5vOU-00099s-2R for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jan 2021 19:54:50 +0100 Original-Received: from localhost ([::1]:56588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5vOT-0005TV-1r for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jan 2021 13:54:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5vNR-0004IB-Mn for emacs-devel@gnu.org; Sat, 30 Jan 2021 13:53:45 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:42029) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5vNP-0002vp-Fl for emacs-devel@gnu.org; Sat, 30 Jan 2021 13:53:45 -0500 X-Originating-IP: 91.129.108.204 Original-Received: from mail.gandi.net (m91-129-108-204.cust.tele2.ee [91.129.108.204]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id C71BAE0004; Sat, 30 Jan 2021 18:53:39 +0000 (UTC) In-Reply-To: <87tuqzzl7m.fsf@gmail.com> (Augusto Stoffel's message of "Fri, 29 Jan 2021 18:50:21 +0100") Received-SPF: pass client-ip=217.70.183.196; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263630 Archived-At: > I have attached a new patch addressing the issues we discussed. I have > also changed the name of the new variable a bit, I hope it's a bit more > self-explanatory now. Thanks for the patch, everything looks good. Now pushed to master. > I have also tested increasing ‘lazy-highlight-buffer-max-at-a-time’ to > 1000. I can't see any loss in responsiveness, except when the old value > of 20 also makes the editor freeze (for instance when searching for > ".*a.*a$" in very large buffer). This is probably a reasonable default. Indeed, there are corner cases that can make isearch unresponsive. Feel free to send more patches when your find better defaults.