From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#31641: 26.1; iter-do variable not left unused warning Date: Fri, 05 Feb 2021 17:12:15 +0000 Message-ID: <87mtwi8mmo.fsf@tcd.ie> References: <20180529131230.kijx2bkcvcqsyhgg@nullprogram.com> <87in76cdpd.fsf@gmail.com> <87czxgtafv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35731"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Christopher Wellons , 31641@debbugs.gnu.org, Noam Postavsky , Stefan Monnier To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 05 19:24:48 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l85mh-0009Ah-Ey for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Feb 2021 19:24:47 +0100 Original-Received: from localhost ([::1]:50412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l85mg-0007Z0-Fj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Feb 2021 13:24:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l84fG-0004ey-LG for bug-gnu-emacs@gnu.org; Fri, 05 Feb 2021 12:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33076) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l84fG-00014f-Dp for bug-gnu-emacs@gnu.org; Fri, 05 Feb 2021 12:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l84fG-0007YC-99 for bug-gnu-emacs@gnu.org; Fri, 05 Feb 2021 12:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Feb 2021 17:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 31641-submit@debbugs.gnu.org id=B31641.161254514628978 (code B ref 31641); Fri, 05 Feb 2021 17:13:02 +0000 Original-Received: (at 31641) by debbugs.gnu.org; 5 Feb 2021 17:12:26 +0000 Original-Received: from localhost ([127.0.0.1]:44622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l84eg-0007XK-A3 for submit@debbugs.gnu.org; Fri, 05 Feb 2021 12:12:26 -0500 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:55607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l84ed-0007X0-UW for 31641@debbugs.gnu.org; Fri, 05 Feb 2021 12:12:24 -0500 Original-Received: by mail-wm1-f42.google.com with SMTP id f16so6584895wmq.5 for <31641@debbugs.gnu.org>; Fri, 05 Feb 2021 09:12:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=T6sVwKYfm3q8O49JW4H7whYl3FdjNS/ApXZexUSpQr0=; b=lvcDN7f4aqrFg0si941CwatflhEVcBgkBudEBTbpLiGu8bm6+5tM3V65o+TmUyZ8cq 9wWKwv2TPDvn74W5b+xTS/PhC6Mg/vN+27MgCySQ/eTsnYYHGW5eDt4Xa8NzGoYZ0Z9h uoM2SWNXNANle0+UnAfhwWTqGRKS49uQ0NuQh+Va3ohC01fLxRG2e5EueBcsQVx8wICG Y8ecVv2r3fGu1P/E5dqAnE0viA83qrQz1WsPfOYgCI3fXNVXeL/lTMr82Z5w+9zA38gQ a6P+RM+gdy6A41Yuw3DGlG+WI3hpHs4KOQP4O+ToJcq/Uii7hmQnhgZV378rNqopvlbb 3X2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=T6sVwKYfm3q8O49JW4H7whYl3FdjNS/ApXZexUSpQr0=; b=iJeHoKoCTWH+LJYSv79eW5M/ecuF2ClFD9TdRRF2nRss7y7Yko+0Z3Da+txKX/1Kgp VWhAHz1fRTT4dDHBI05q8s27EqYk1JLGtHhY39zml0va2lIq8n9RIl+pHrfHTfmMdnB3 5N3NAXvuVZELV1NlaJJaaBSVboh0Su+xlKZjthdYyMLmN1rNvtW5cVmwZwGnVIOGAO1p dpbQL3WN6a/eqCztkzv73nlV242wB/mp1wsMz05dlhvJ5DIySN1roSZ2LQlEUEKSfHRr qPGDPq2TLP6hDtli5ToK3eRMFXu/RbYPdsCRIY/TiV4c3vyjUl3Zpyr42jFcMbNe1bUa LL/A== X-Gm-Message-State: AOAM531T8zOiOda9fXvxIp0iBYkBZoxSuceyVL6WvnhDP/DAdEoOMEqF b5W0Ps9LDTkNYKoNQa8leTGnCg== X-Google-Smtp-Source: ABdhPJy8g236GMlZU4i6UiSUwVoAd7XZf35h44yDneAOu1/GyCQuK12R7GQg49NRIWMlwos+S0BEfQ== X-Received: by 2002:a7b:c21a:: with SMTP id x26mr4469435wmi.50.1612545138096; Fri, 05 Feb 2021 09:12:18 -0800 (PST) Original-Received: from localhost ([64.43.144.22]) by smtp.gmail.com with ESMTPSA id i8sm13807807wry.90.2021.02.05.09.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 09:12:17 -0800 (PST) In-Reply-To: <87czxgtafv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 04 Feb 2021 11:05:24 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199398 Archived-At: Lars Ingebrigtsen writes: > diff --git a/lisp/emacs-lisp/generator.el b/lisp/emacs-lisp/generator.el > index 9eb6d95964..0b644cc72c 100644 > --- a/lisp/emacs-lisp/generator.el > +++ b/lisp/emacs-lisp/generator.el > @@ -731,7 +731,10 @@ iter-do > (,it-symbol ,iterator)) > (while (not ,done-symbol) > (condition-case ,condition-symbol > - (setf ,var (iter-next ,it-symbol)) > + ;; Variables that start with an underscore shouldn't be set. > + ,(if (string-match-p "\\`_" (symbol-name var)) > + nil > + `(setf ,var (iter-next ,it-symbol))) Nit - AKA the following? ,(unless (string-prefix-p "_" (symbol-name var)) `(setf ,var (iter-next ,it-symbol))) -- Basil