From: Pablo Barraza Cornejo <pbarrazacornejo@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Fix numbering of captioned images
Date: Thu, 29 Apr 2021 20:52:53 -0600 [thread overview]
Message-ID: <87mttgiiuy.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
When exporting to HTML, the exporter is supposed to check if there
are additional constraints over a paragraph using
`org-html-standalone-image-predicate'. A misplaced quote causes
`org-html-standalone-image-p' to not apply them.
To number captions on images the `org-html-paragraph' binds
`org-html-standalone-image-predicate' to
`org-html--has-caption-p', but since it gets ignored,
`org-export-get-ordinal' considers all standalone images, not just
captioned ones. This throws off the numbering.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ox-html.el-inline-image-export-Fix-caption-numbering.patch --]
[-- Type: text/x-patch, Size: 1035 bytes --]
From 85e0b2da37f914458d71bd3a5797298ca3a4e0ce Mon Sep 17 00:00:00 2001
From: Pablo Barraza Cornejo <pbarrazacornejo@gmail.com>
Date: Thu, 29 Apr 2021 20:15:08 -0600
Subject: [PATCH] ox-html.el/inline-image export: Fix caption numbering.
* lisp/ox-html.el (org-html-standalone-image-p): Remove quote which
causes `org-html-standalone-image-p' to not check if `org-html-standalone-image-predicate' is bound.
TINYCHANGE
---
lisp/ox-html.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index 47122314c..df270b22b 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -3039,7 +3039,7 @@ images, set it to:
(`paragraph element)
(`link (org-export-get-parent element)))))
(and (eq (org-element-type paragraph) 'paragraph)
- (or (not (fboundp 'org-html-standalone-image-predicate))
+ (or (not (fboundp org-html-standalone-image-predicate))
(funcall org-html-standalone-image-predicate paragraph))
(catch 'exit
(let ((link-count 0))
--
2.31.1
next reply other threads:[~2021-04-30 3:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 2:52 Pablo Barraza Cornejo [this message]
2021-04-30 4:54 ` [PATCH] Fix numbering of captioned images Kyle Meyer
2021-04-30 5:44 ` Pablo Barraza Cornejo
2021-05-01 4:43 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mttgiiuy.fsf@gmail.com \
--to=pbarrazacornejo@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.