Re: [PATCH] When deleting in bookmark menu, prompt for confirmation.

[Lars Ingebrigtsen <larsi@gnus.org>]

Karl Fogel <kfogel@red-bean.com> writes:

> I wanted to run this by folks here to get opinions/review before
> committing.  It stems from a suggestion by Oliver Taylor in a thread
> on the Emacs Humanites mailing list (the thread is linked to from the
> commit message).

[...]

>   (bookmark-menu-confirm-deletion): New defcustom.

In general, I think it's better to offer undo instead of prompting.
That's not always possible, but I think in the bookmark case, that
shouldn't be too difficult -- just register an undo action that inserts
the items that were removed, I think?

But if we want to do the prompt, just a tiny comment:

> +(defcustom bookmark-menu-confirm-deletion t
> +  "Non-nil means prompt for confirmation when executing the deletion
> +of bookmarks marked for deletion in a bookmark menu buffer.  Nil
> +means don't prompt for confirmation."
> +  :type 'boolean)

:version should be added, and the first line should be a complete
sentence.  (And "nil" shouldn't be capitalised, even if it starts the
sentence.) 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no