From: Lars Ingebrigtsen <larsi@gnus.org>
To: Boruch Baum <boruch_baum@gmx.com>
Cc: 47784@debbugs.gnu.org
Subject: bug#47784: 27.2: ses-header-row [PATCH INCLUDED]
Date: Wed, 05 May 2021 15:08:52 +0200 [thread overview]
Message-ID: <87mtt95nvf.fsf@gnus.org> (raw)
In-Reply-To: <20210415033147.a3hoclq24colpjf7@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 14 Apr 2021 23:31:47 -0400")
Boruch Baum <boruch_baum@gmx.com> writes:
> Two patch files are attached.
>
> + ses-header-row.patch
>
> + Function `ses-set-header-row' was determining the current row based
> upon variable `ses--curcell', but that variable is NIL until one
> begins an operation on a cell (eg. keybindings '=', '"'), so
> navigating to a row was insufficient to select that row, and further
> generated an ERROR because the code was not expecting a NIL value for
> variable `ses--curcell'
>
> + Using function `user-error' instead of `error' doesn't spawn a
> debug session and backtrace buffer when variable
> `toggle-debug-on-error' is set.
>
> + ses-user-error.patch
>
> + Quasi-randomly replaces some calls to function `error' with
> `user-error'.
Looks good to me, so I've applied both patches to Emacs 28. Eli had
some questions about the usage of user-error instead of error in the
second patch, but as far as I can tell, using `user-error' is indeed the
right thing here, because the errors in question seem more user
initiated.
I've got two tiny comments about the patch. First of all, the
whitespace seemed odd:
lisp/ses.el:3462: space before tab in indent.
+ (currow (1+ (car (ses-sym-rowcol curcell)))))
So I fixed that up, but I've seen that in other patches -- could you
have a look and see what's causing this mixture of tab and spaces?
The other comment is that it would be nice to have ChangeLog-style
commit messages -- use `C-x 4 a' to format one before sending patches.
Less work when applying the patch. :-)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-05-05 13:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 3:31 bug#47784: 27.2: ses-header-row [PATCH INCLUDED] Boruch Baum
2021-04-17 19:30 ` Eli Zaretskii
2021-04-19 9:24 ` Boruch Baum
2021-04-19 13:03 ` Eli Zaretskii
2021-04-19 13:27 ` Boruch Baum
2021-04-21 0:02 ` Stefan Kangas
2021-04-21 9:23 ` Eli Zaretskii
2021-05-05 13:08 ` Lars Ingebrigtsen [this message]
2021-05-05 16:40 ` Boruch Baum
2021-05-05 19:15 ` Eli Zaretskii
2021-05-05 19:40 ` Boruch Baum
2021-05-05 19:46 ` Eli Zaretskii
2021-05-06 8:10 ` Robert Pluim
2021-05-06 11:05 ` Boruch Baum
2021-05-06 8:17 ` Lars Ingebrigtsen
2021-05-06 10:16 ` Boruch Baum
2021-05-07 11:14 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtt95nvf.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=47784@debbugs.gnu.org \
--cc=boruch_baum@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.