From: Ingo Lohmar <ingo.lohmar@posteo.net>
To: emacs-devel@gnu.org
Subject: sql change: NEWS entry necessary? or no defcustoms at all?
Date: Wed, 26 May 2021 19:26:18 +0000 [thread overview]
Message-ID: <87mtshguud.fsf@kenko.localhost.com> (raw)
A week ago, I added (on master, dac694b8bb) the defcustom
`sql-postgres-statement-starters'. It is a regexp for
sql-product-specific additional statement start commands, analogous to
the existing `sql-oracle-statement-starters'. It now occurs to me that
my commit may lack a NEWS entry, after all it's a new user option.
The reason I did not add an entry, and that now I am asking for
guidance, is that this "option" should, IMO, ideally be a defvar (or
even defconst), it's *not* really intended for customization, but just
states some knowledge about PostgreSQL. The reason I still did use a
defcustom was only for the analogy with the Oracle-specific variable.
WDYT?
next reply other threads:[~2021-05-26 19:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 19:26 Ingo Lohmar [this message]
2021-05-26 21:39 ` sql change: NEWS entry necessary? or no defcustoms at all? Lars Ingebrigtsen
2021-05-27 6:48 ` Eli Zaretskii
2021-05-27 20:57 ` Ingo Lohmar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtshguud.fsf@kenko.localhost.com \
--to=ingo.lohmar@posteo.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.