From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tyler Grinn Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New packages: boxy, boxy-headlines Date: Tue, 05 Oct 2021 12:35:59 -0400 Message-ID: <87mtnn77kg.fsf@gmail.com> References: <87zgro8sdr.fsf@gmail.com> <87v92c7571.fsf@gmail.com> <87r1d06sp7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23569"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 05 19:19:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXo6f-0005tb-L9 for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Oct 2021 19:19:57 +0200 Original-Received: from localhost ([::1]:51212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXo6d-0003ZF-IX for ged-emacs-devel@m.gmane-mx.org; Tue, 05 Oct 2021 13:19:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXnQG-0000zh-8i for emacs-devel@gnu.org; Tue, 05 Oct 2021 12:36:08 -0400 Original-Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]:36533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXnQB-00062c-4N for emacs-devel@gnu.org; Tue, 05 Oct 2021 12:36:07 -0400 Original-Received: by mail-qt1-x82d.google.com with SMTP id l13so19707926qtv.3 for ; Tue, 05 Oct 2021 09:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=89bOYUy7hKNaTZrTmYz974dw6dp/e92D6zGCm9pt34E=; b=hSZMj9GLxQz2305pt8rxaBLh/kl+JbA3U7Z9uZAvBJ37KWBR4rqx8C5pjzaOl8yIKq Ku7thCjtY9/ZbKy4hPBROd4Lu8XjugBePYj2tY7gP8Jiw6OERV/swBjvQ1pdHzaLK+mi dykFGaimE3JvwKnv4h1ksQvplcy65YeeU8EvwbyZziVYDfahwQK1Kvgys8GntHhNYh34 JbSJB5afq3CqAEM07OaaNeWHXAR1E+5f/WOCpIninkd4AyFdHi+fqpLsksCmqa7nJfI+ sCx4uExWfdIbZDk5S9LmwvZzqVYdz1+dvt7yUT9DbPBmf/HxeyhrCOxPHqcTocERk3vZ uEUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=89bOYUy7hKNaTZrTmYz974dw6dp/e92D6zGCm9pt34E=; b=aYF6+I8vXN0+vmlD56uKnC3lDlTqLgW0FYQbtDiXF8Z5sypFFB86YKw/8rT9rYs1q9 YuUaTPkbIB+Nb9XFYF5QcpPLU21Ei319YbiHZlvGyh7d3nfk706/TCFdbUyEZ/OYPS6W 2lG6OVSNFnXHkA1SQIguJPvuAwfBTSH2HbXe/cywCTvqX9uDShnk2CmbFPDkhAcZPpoX Y5ughL/hPb5kh62KFJNsswWhSyEG1UaxvnlaqEV9GzC3Y25XpBmVp3jGVTzw/13ImyRy xpQd/RTRs1B2SwbaABhPIK8LfCsUJh2mk6X8YxNAvojwFRAn6f5zHNPZT470o/W6prsL tNiw== X-Gm-Message-State: AOAM5328VZ/nbZpXF7SjTh4vQlk1fCCD3g9ncq427KMRZm54FlAWL1LL 5rJ+wVNTzOHM82JHFTpS36Zl0ETJVtLU+w== X-Google-Smtp-Source: ABdhPJzzWwqRSdTPa6s9noW6w+N7XHmT7+LNLOqIybx5MXIWa4s3XxWFE6yqggiASE+0c5w22O50yg== X-Received: by 2002:ac8:7d4c:: with SMTP id h12mr20706804qtb.181.1633451761160; Tue, 05 Oct 2021 09:36:01 -0700 (PDT) Original-Received: from tyler-hp ([2601:410:4301:3e90::7c4]) by smtp.gmail.com with ESMTPSA id j184sm9970292qkd.74.2021.10.05.09.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 09:36:00 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Tue, 05 Oct 2021 08:30:34 -0400") Received-SPF: pass client-ip=2607:f8b0:4864:20::82d; envelope-from=tylergrinn@gmail.com; helo=mail-qt1-x82d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276348 Archived-At: Stefan Monnier writes: >> That's what I've gathered to, so to get around that is why I'm using >> face-spec-set. The behavior I want is this: update the face if a user >> has not independently customized it already. If I simply changed the >> defface, only new users would get the new theme. Existing users would >> have to re-apply the standard definition or restart emacs. > > What you want is not specific to your theme, so it's best to > fix it at its source rather than work around it with non-standard code. > I suggest you `M-x report-emacs-bug` and request this behavior. > Will do. >> (boxy--inherited boxy--padding-y :padding-y boxy--default-padding-y) >> >> But this results in >> Warning: Unknown slot =E2=80=98:padding-y=E2=80=99 >> Warning: Unknown slot =E2=80=98:parent=E2=80=99 > > You don't have any slot named `:parent` nor `:padding-y`. > You're confusing the slots's names with the slots's initargs. > > You want: > > (slot-boundp box 'parent) > > rather than > > (slot-boundp box :parent) > > BTW, while I don't like `defclass` (preferring `cl-defstruct`), one of > its neat features is the ability to override `slot-unbound`, which > should let you implement in a kind of "transparent" way the kind of > fallback mechanism that you're trying to implement with > `boxy--inherited`. > That's an interesting revelation! I'll have to give that some thought but I think it'll be useful for more than just inheritance. > >>> + (let ((inhibit-message t)) ;FIXME: Please report the message as = an error. >>> (setq indent-tabs-mode nil) >>> (cursor-sensor-mode t) >>> (toggle-truncate-lines t))) >> >> This doesn't even do what I want. I don't want 'Truncate long lines >> enabled' to be printed to the minibuffer when entering boxy mode, but it >> shows regardless. What exactly does the FIXME mean here and how do I >> stop that message? > > The FIXME means that `toggle-truncate-lines` should not emit the message > at all in this case, just like `cursor-sensor-mode` doesn't emit > a message when called as above. > IOW, you should `M-x report-emacs-bug` and complain about it. > Ok will do. Thanks again for taking a look at this. I had some issues with the ELPA deployment but I think I took care of them. It looks like ELPA grabbed code from before I sent the first email. From the beginning of the boxy-headlines repo I've been using 1.0.0 as the version so maybe that explains it. There's a call to org-real--add-headline which was renamed to boxy-headlines--add-headline. I just pushed out version 1.0.1 with your changes to both projects, so that should update boxy-headlines, right? It looks like .elpaignore should only use relative paths. I will update those accordingly so the test cases in boxy.el are not compiled. The brief for boxy-headlines looks a little awkward in org format. If I add the README.org and demo folder to .elpaignore it should fall back to the "Commentary" and shrink the package size considerably. Tyler