From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51550: 29.0.50; Customize Group INS buttons sometimes don't have a left box line Date: Tue, 28 Dec 2021 21:24:41 +0800 Message-ID: <87mtkkvp46.fsf@yahoo.com> References: <87ee80gezy.fsf.ref@yahoo.com> <87ee80gezy.fsf@yahoo.com> <83a6iolzjd.fsf@gnu.org> <87zgqnk74n.fsf@rub.de> <83ee7zll84.fsf@gnu.org> <87wnlrfhdk.fsf@yahoo.com> <831r3ylk6o.fsf@gnu.org> <87r1bxer97.fsf@yahoo.com> <83pmrhien9.fsf@gnu.org> <87mtkmz5ht.fsf@yahoo.com> <83sfuem70q.fsf@gnu.org> <87ee5xzhrr.fsf@yahoo.com> <835yr8nbqm.fsf@gnu.org> <87zgokvqxp.fsf@yahoo.com> <83tueslvgj.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9571"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: stephen.berman@gmx.net, stefan@marxist.se, 51550@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 28 14:25:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2CTZ-0002Gh-5u for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 14:25:13 +0100 Original-Received: from localhost ([::1]:37496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2CTX-0004uD-AK for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 08:25:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2CTP-0004sZ-0v for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 08:25:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2CTO-00019k-Nm for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 08:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n2CTO-0005aC-EP for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 08:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Dec 2021 13:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51550 X-GNU-PR-Package: emacs Original-Received: via spool by 51550-submit@debbugs.gnu.org id=B51550.164069790121446 (code B ref 51550); Tue, 28 Dec 2021 13:25:02 +0000 Original-Received: (at 51550) by debbugs.gnu.org; 28 Dec 2021 13:25:01 +0000 Original-Received: from localhost ([127.0.0.1]:45341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2CTM-0005Zq-Nv for submit@debbugs.gnu.org; Tue, 28 Dec 2021 08:25:00 -0500 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:42850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2CTK-0005Zb-Hr for 51550@debbugs.gnu.org; Tue, 28 Dec 2021 08:24:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640697892; bh=ZO0VAOSB6KErFZxOcZuh/BOtINHph1sPwlZMVwsWXcw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=IxdnAtmBXQFGPM1nYPhGK2TRHhmrr/fqEQFcsVAA3ExIHp4LHcHHx+kWqGBQJIV4rXh4xhHTb6UkuwhpjIplgydTL4pyewHwzZLDmmjKHlzX0/6f0gjVyF6iyFL8BKHOYj0MfDLCHV0cLZy/Xtt3j57/Vs9+9UKUV0vrsMIOtNlysjnMQvnR30x65IthuvOFrGyB9v1jtxAVRXZtvOaQl13Qv84syX1v9GA+2iTkIj1fQjKoBSNqXxOz3n9hqQWkmJv7iNG1tnO/ZYVBda66vvaQM1ORljPQsl3tZFpx46s0ccxpbfpSHiWZRMPupXRP31P5lqssVfYEABcLRb+Cmg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640697892; bh=l19FK2U5kcXQehMRagANWopxlp8zYLQymD1UY9tmRVF=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=LfShWAMCd/coCZBZi1JMS9fqb+5+MGK+JM07I2BDnAGZL9ORjx28xq2/sA7mImNGpH2sEQuF6XgNNvOt37T/vXREh8D3gRxmZOZmW7rWIa/hFY4grlYIwNv/eNkSmTh2JWXFSKVBLvDDQ96Tq7eq4guPqj/ajktGwZXqRgd+mgG0bq7ZlkhEbTyAQIB6E3qlwmgPLouAvFomHZq5JiZxdztg3t+sLg2UydzAwgvbKiBD7X704RVokqdhE4ak1SaaYmI89DcVfZTKoYnmYlOqmtS+aYGhHE69TwD/c+u/uGxIp2u1CkDVdsmf8t7VDw2jLSlOccbTsAJJzbCavYGkAw== X-YMail-OSG: 3anMd14VM1llbJzN0dBLx.CNhaXUty95FVagfcsbRrzkHQHQJbipBrir4xcoqeP diXlA3MxGTSlfq5jaxupTDwIsOvpIJ3WA0JeL9LZnnHtbzwEpTDvL0xTzDqpfpUqKHUh1kWa.A9f hqO6gVFN5IxdkhqYAFj2tG56whr340LCuomFY0h1ieVd7GEP39ZkiNTYNyegJ2sbUSkn.ZUQ0JlA r1VvrWO0hiCkBZ1vhOYqtKkeUBFfuKKdaLI4rEY89f0GPeJdTTmsf7Ejck.Y6lO5S9NGGEDLPdhp CQALrC0JU3Zac.v71jjhHQsgskitLwFgYHbG1FXpcYum0V0kZPS_FVvF1xI_xToKRM9SS.70qT.D YHYZBsFTTNocJeHMWWxPQs6V5PnWanAsqgsjctzOPyYTzmKZ.BxRpXw8yZ1i03kShJi.Pr3KoBJF rLsoO1ELwYGq.Da8.RUw9xXefgTeaKTyLp1yOLYLRZQxpuTDrgF.oKrcMhXPzCIYDs4NaD15HkjK KPIkUevzZ2P_Hzf0IHuJGQNmiGAjPd9YNA8nPEUsM.VN8YjzR1FQZfsYhMv8usFkmnCrwShF3xtO UKSZiAvLv5iVBy1ZZri6HVAvVfUD.2iqXp2lImyzNUFCwoPGRUFyhNglNz7EzEoUwJsgtoPYpS4X G7Ygt4I67vQpykAWVTtTIURgPkgp_4tgv2UgHSuJp3HyCNZcFivXesGgjs5qEuANEQKIZKb26eN2 vcocaZeXn..IaCdaw_1Icg58BWreWPn9.wKAV3ZOFqPBITrh.BW3hTdW2mDzoCXIETkXlwbDkG01 LN9JOBPXunMmS9ptmRVVOLElmZueyOeaZ8ji8MuMU7 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Tue, 28 Dec 2021 13:24:52 +0000 Original-Received: by kubenode502.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID eb94992028a3bda34baa8f14d48aaa4c; Tue, 28 Dec 2021 13:24:49 +0000 (UTC) In-Reply-To: <83tueslvgj.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 28 Dec 2021 15:17:48 +0200") X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223252 Archived-At: Eli Zaretskii writes: >> Yes, widget-field has a box on master, while it doesn't on emacs-28. > The other way around, I guess? Causing widget-field to have a box (which gets extended to the end of the line) makes the custom button on the next line lose its start box line, so it's not the other way around. > Which buggy code was that, and where did I suggest disabling it? The code that added a box to widget-field. But it seems that Stefan suggested to disable it, and you only happened to concur. Maybe this will help jog your memory (but you really ought to look at the whole bug report.) Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Wed, 3 Nov 2021 00:03:00 -0700 >> Cc: stephen.berman@gmx.net, 51550@debbugs.gnu.org >> >> It seems like the entire line is shifted a pixel to the left when using >> :box, but only on the second consecutive line. I tried experimenting >> with :box 1, :box -1, and I get the same result. >> >> Are we sure that's not a bug in the display code? > > I don't know, the arrangement of faces on that button is complicated, > to say the least. I don't think I even understand which parts of the > display is the widget-field face applied to. Can you show the > complete definition of the button face at the first line and the > non-first line? > >> In any case, we could revert the commit for emacs-28 and continue investigating >> on master. > > Yes, I think we should do that. Thanks.