From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Peter =?UTF-8?Q?M=C3=BCnster?= Newsgroups: gmane.emacs.bugs Subject: bug#53599: 29.0.50; image-dired-mouse-toggle-mark very slow Date: Mon, 31 Jan 2022 10:02:03 +0100 Message-ID: <87mtjc5ldg.fsf@a16n.net> References: <87r18sfazc.fsf@a16n.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20332"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 53599@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 31 10:08:43 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nESfy-00057f-P2 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 Jan 2022 10:08:42 +0100 Original-Received: from localhost ([::1]:46446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nESfw-0008TD-9O for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 Jan 2022 04:08:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nESbH-0004kk-98 for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 04:03:51 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45421) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nESaT-0003cl-R3 for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 04:03:50 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nESaT-0001oq-NO for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 04:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Peter =?UTF-8?Q?M=C3=BCnster?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Jan 2022 09:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53599 X-GNU-PR-Package: emacs Original-Received: via spool by 53599-submit@debbugs.gnu.org id=B53599.16436197366931 (code B ref 53599); Mon, 31 Jan 2022 09:03:01 +0000 Original-Received: (at 53599) by debbugs.gnu.org; 31 Jan 2022 09:02:16 +0000 Original-Received: from localhost ([127.0.0.1]:38324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nESZk-0001nj-Gq for submit@debbugs.gnu.org; Mon, 31 Jan 2022 04:02:16 -0500 Original-Received: from server.a16n.net ([178.33.238.77]:46516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nESZe-0001nN-Oz for 53599@debbugs.gnu.org; Mon, 31 Jan 2022 04:02:15 -0500 Original-Received: from ws.localdomain (arennes-657-1-259-127.w2-14.abo.wanadoo.fr [2.14.213.127]) by server.a16n.net (Postfix) with ESMTPSA id C85C643E054D for <53599@debbugs.gnu.org>; Mon, 31 Jan 2022 10:02:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=a16n.net; s=a16n; t=1643619723; bh=R5cuRCYzJXJTZVC1Y0ux5b28aTES6SqG5TdpFjrvHDU=; h=From:To:Subject:References:Date:In-Reply-To; b=g0BkfDeV75Tozjogt8BxiVegbIjgDyX0SuadT+DeIDkzACXXWa6W1dZa02LmtdO6S h6A1BrTEgypV7P2UdAf13aK/lWCEnZu+3DY4SlPQ4PRtIzZCkO2bJbuyc92/Nw1vGV Cwv8qqwXx6v8LqxVnExCn2Rz/AtVEfyeSWjo/ZFTYPQbPq70Di91whyfcm5TI4N06I ilB5bYAMKsKCFZFx0zoM4M02r0HAu511DkvrKcQXe8c58NGeDa/LojS8pIJlEiXw+n VwQotxbd7cnaWTMyG0VMgkPEflGghOdmgJZytckwuYgMgtplkWMP0X/fOhYl5En73Z KQCBNIBLZQvuQ== Original-Received: by ws.localdomain (Postfix, from userid 1000) id 4334B20599; Mon, 31 Jan 2022 10:02:03 +0100 (CET) In-Reply-To: <87r18sfazc.fsf@a16n.net> ("Peter =?UTF-8?Q?M=C3=BCnster?="'s message of "Fri, 28 Jan 2022 10:47:19 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225656 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, Jan 28 2022, Peter M=C3=BCnster wrote: > What could be a good way to avoid the repeated calls to > image-dired-thumb-update-marks please? This works, but I don't know if it's not too hackish: diff --git a/lisp/image-dired.el b/lisp/image-dired.el index 9b0bbb70df..e5ccc17154 100644 =2D-- a/lisp/image-dired.el +++ b/lisp/image-dired.el @@ -2392,17 +2390,20 @@ image-dired-mouse-toggle-mark Track this in associated Dired buffer if `image-dired-track-movement' is non-nil." (interactive "e") =2D (if (use-region-p) =2D (let ((end (region-end))) =2D (save-excursion =2D (goto-char (region-beginning)) =2D (while (<=3D (point) end) =2D (when (image-dired-image-at-point-p) =2D (image-dired-mouse-toggle-mark-1)) =2D (forward-char)))) =2D (mouse-set-point event) =2D (goto-char (posn-point (event-end event))) =2D (image-dired-mouse-toggle-mark-1)) + (let ((idtum-orig (symbol-function 'image-dired-thumb-update-marks))) + (defun image-dired-thumb-update-marks ()) + (if (use-region-p) + (let ((end (region-end))) + (save-excursion + (goto-char (region-beginning)) + (while (<=3D (point) end) + (when (image-dired-image-at-point-p) + (image-dired-mouse-toggle-mark-1)) + (forward-char)))) + (mouse-set-point event) + (goto-char (posn-point (event-end event))) + (image-dired-mouse-toggle-mark-1)) + (fset 'image-dired-thumb-update-marks idtum-orig)) (image-dired-thumb-update-marks)) =20 (defun image-dired-dired-display-properties () What do you think? =2D-=20 Peter --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iGoEARECACoWIQS/5hHRBUjla4uZVXU6jitvQ7HLaAUCYfeliwwccG1AYTE2bi5u ZXQACgkQOo4rb0Oxy2ijAwCgsr/XDto7SFxbHyySYjf+7+DRnmEAoIgwfxe4+sR8 LyNaQBi+nNIKdFG0 =yCqA -----END PGP SIGNATURE----- --=-=-=--