From: Po Lu <luangruo@yahoo.com>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 7f9335f91d: Implement _NET_WM_USER_TIME protocol
Date: Thu, 10 Feb 2022 10:00:37 +0800 [thread overview]
Message-ID: <87mtizzdiy.fsf@yahoo.com> (raw)
In-Reply-To: <87zgn02h28.fsf@gmail.com> (Robert Pluim's message of "Wed, 09 Feb 2022 16:30:39 +0100")
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Wed, 9 Feb 2022 03:14:53 -0500 (EST), Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> said:
>
> Po> branch: master
> Po> commit 7f9335f91d3e0ecdff9c3adb93aad08454002035
> Po> Author: Po Lu <luangruo@yahoo.com>
> Po> Commit: Po Lu <luangruo@yahoo.com>
>
> Po> Implement _NET_WM_USER_TIME protocol
>
> Po> * src/xterm.c (x_display_set_last_user_time): Set user time on
> Po> the active window.
> Po> (handle_one_xevent): Only set user time when the user actually
> Po> interacted with Emacs.
> Po> (x_make_frame_visible): Set user time if non-zero.
> Po> (x_term_init): Intern `_NET_WM_USER_TIME'.
> Po> * src/xterm.h (struct x_display_info): New field
> Po> `Xatom_net_wm_user_time'.
> Po> (x_display_set_last_user_time): Implement in xterm.c instead.
> Po> ---
> Po> src/xterm.c | 101 ++++++++++++++++++++++++++++++++++++++----------------------
> Po> src/xterm.h | 14 +++------
> Po> 2 files changed, 69 insertions(+), 46 deletions(-)
>
> CC xterm.o
> xterm.c: In function ‘handle_one_xevent’:
> xterm.c:11762:6: error: a label can only be part of a statement and a declaration is not a statement
> 11762 | XKeyPressedEvent xkey;
> | ^~~~~~~~~~~~~~~~
> make[1]: *** [Makefile:414: xterm.o] Error 1
> make[1]: Leaving directory '/home/rpluim/repos/emacs/src'
> make: *** [Makefile:469: src] Error 2
>
> Are you compiling emacs with a c++ compiler?
No, and that can't work anyway. (But I see the problem now, thanks.)
next prev parent reply other threads:[~2022-02-10 2:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164439449311.24347.14340914112590544821@vcs2.savannah.gnu.org>
[not found] ` <20220209081453.69C44C0DA3A@vcs2.savannah.gnu.org>
2022-02-09 15:30 ` master 7f9335f91d: Implement _NET_WM_USER_TIME protocol Robert Pluim
2022-02-10 2:00 ` Po Lu [this message]
2022-02-09 16:24 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtizzdiy.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.