From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add user stylesheet support for doc-view EPUB support Date: Sun, 06 Mar 2022 23:07:38 +0100 Message-ID: <87mti2env9.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17545"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Daniel Nicolai , emacs-devel@gnu.org To: Kjartan Oli Agustsson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 06 23:08:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQz3H-0004Mu-LR for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Mar 2022 23:08:31 +0100 Original-Received: from localhost ([::1]:49918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQz3G-0003uG-30 for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Mar 2022 17:08:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQz2a-0003EA-Ji for emacs-devel@gnu.org; Sun, 06 Mar 2022 17:07:48 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=38416 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQz2Z-0005qT-5y for emacs-devel@gnu.org; Sun, 06 Mar 2022 17:07:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=t3TeOV1F5LvD8WgEFoWviqCHOpc/9y+HL2TXG/M5UKs=; b=IE78pJg1VRyuCQvYeaAc5XjCgP 6S+W83NBkkSGUBcQKwNr8qMfEzz+dl815pt8/Dgoe6L7xHcA0WhzqgRo6hpzBSShLJX+VjenfTPfO YM0w/hu+s1Y1X5ZaUuVlEscfr+h6O5gV3ck9/pqTmpxiYu33puINOdpZzS2Ngo5lfmcs=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQz2S-0002Cn-9w; Sun, 06 Mar 2022 23:07:42 +0100 X-Now-Playing: The Raincoats's _Odyshape_: "Dancing in My Head" In-Reply-To: (Kjartan Oli Agustsson's message of "Sun, 06 Mar 2022 17:12:50 +0000") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286865 Archived-At: Kjartan Oli Agustsson writes: > @@ -1079,6 +1085,9 @@ doc-view-start-process Adding support for CSS makes sense to me. But is this the best place to add it? It's the general function that's called for all the different conversions? > (let* ((default-directory (or (unhandled-file-name-directory > default-directory) > (expand-file-name "~/"))) > + (args (if (and (eq doc-view-doc-type 'epub) > + doc-view-mutool-user-stylesheet) > + (cons (car args) (cons (format "-U%s" (expand-file-name doc-view-mutool-user-stylesheet)) (cdr args))))) And I don't think this can be right -- for instance, it's called here: (doc-view-start-process "dvi->pdf" doc-view-dvipdfm-program (list "-o" pdf dvi) callback))) And you're splicing in the stylesheet after "-o" (potentially -- I'm not that familiar with the doc-view code), which will break things. (And if doc-view-mutool-user-stylesheet is nil, then args will also be bound to nil, which will make all the calls fail.) I've added Daniel to the CCs; perhaps he has further comments. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no