From: Lars Ingebrigtsen <larsi@gnus.org>
To: Kjartan Oli Agustsson <kjartanoli@outlook.com>
Cc: Daniel Nicolai <dalanicolai@gmail.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] Add user stylesheet support for doc-view EPUB support
Date: Sun, 06 Mar 2022 23:07:38 +0100 [thread overview]
Message-ID: <87mti2env9.fsf@gnus.org> (raw)
In-Reply-To: <GV1P193MB23100435726A07452C3EF90FDF079@GV1P193MB2310.EURP193.PROD.OUTLOOK.COM> (Kjartan Oli Agustsson's message of "Sun, 06 Mar 2022 17:12:50 +0000")
Kjartan Oli Agustsson <kjartanoli@outlook.com> writes:
> @@ -1079,6 +1085,9 @@ doc-view-start-process
Adding support for CSS makes sense to me. But is this the best place to
add it? It's the general function that's called for all the different
conversions?
> (let* ((default-directory (or (unhandled-file-name-directory
> default-directory)
> (expand-file-name "~/")))
> + (args (if (and (eq doc-view-doc-type 'epub)
> + doc-view-mutool-user-stylesheet)
> + (cons (car args) (cons (format "-U%s" (expand-file-name doc-view-mutool-user-stylesheet)) (cdr args)))))
And I don't think this can be right -- for instance, it's called here:
(doc-view-start-process "dvi->pdf" doc-view-dvipdfm-program
(list "-o" pdf dvi)
callback)))
And you're splicing in the stylesheet after "-o" (potentially -- I'm not
that familiar with the doc-view code), which will break things. (And if
doc-view-mutool-user-stylesheet is nil, then args will also be bound to
nil, which will make all the calls fail.)
I've added Daniel to the CCs; perhaps he has further comments.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-03-06 22:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-06 17:12 [PATCH] Add user stylesheet support for doc-view EPUB support Kjartan Oli Agustsson
2022-03-06 22:07 ` Lars Ingebrigtsen [this message]
2022-03-07 0:17 ` Kjartan Oli Agustsson
2022-03-07 0:50 ` Kjartan Oli Agustsson
2022-03-07 16:31 ` Lars Ingebrigtsen
2022-03-08 23:06 ` Kjartan Oli Agustsson
2022-03-09 13:59 ` Lars Ingebrigtsen
2022-03-09 22:34 ` Kjartan Oli Agustsson
2022-03-12 16:40 ` Lars Ingebrigtsen
2022-03-14 10:25 ` Kjartan Oli Agustsson
2022-03-14 10:32 ` Lars Ingebrigtsen
2022-03-14 11:17 ` Kjartan Oli Agustsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mti2env9.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=dalanicolai@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=kjartanoli@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.