From: Michael Albinus <michael.albinus@gmx.de>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 54606@debbugs.gnu.org
Subject: bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers
Date: Wed, 30 Mar 2022 13:51:57 +0200 [thread overview]
Message-ID: <87mth7bqua.fsf@gmx.de> (raw)
In-Reply-To: <b2b01423d17b33974169d1e6d2193003@webmail.orcon.net.nz> (Phil Sainty's message of "Thu, 31 Mar 2022 00:43:23 +1300")
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
Phil Sainty <psainty@orcon.net.nz> writes:
Hi Phil,
> I've just tested with this, and it solves the immediate problem, but
> it's slow. In my test case it's taking ~2s to switch between images,
> whereas it takes only a fraction of a second when I'm ignoring remote
> dired buffers by adding (not (file-remote-p default-directory)) to
> the conditions.
>
> I have 15 remote dired buffers (about half of which are using multi-
> hops), which isn't a small number but also isn't big, so I think that
> `non-essential' seems inadequate here (unless this is significantly
> more efficient in newer versions).
There is also a change in Tramp of Emacs master, which is relevant in
this context. Do you have a chance to test that Emacs version?
Otherwise, does the appended patch for Emacs 27 make a difference? I
haven't tested it with Emacs 27, though.
> -Phil
Best regards, Michael.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 514 bytes --]
*** /tmp/ediffwcSDZb 2022-03-30 13:50:29.736061472 +0200
--- /home/albinus/src/emacs-27/lisp/net/tramp-sh.el 2022-03-30 13:50:18.051914192 +0200
***************
*** 4958,4963 ****
--- 4958,4964 ----
;; If Tramp opens the same connection within a short time frame,
;; there is a problem. We shall signal this.
(unless (or (process-live-p p)
+ (and (processp p) (not non-essential))
(not (tramp-file-name-equal-p
vec (car tramp-current-connection)))
(time-less-p
next prev parent reply other threads:[~2022-03-30 11:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 10:13 bug#54606: 27.1; next/previous image command in image-mode triggers tramp connections for all remote dired buffers Phil Sainty
2022-03-29 13:03 ` Lars Ingebrigtsen
2022-03-29 13:09 ` Michael Albinus
2022-03-30 11:43 ` Phil Sainty
2022-03-30 11:51 ` Michael Albinus [this message]
2022-03-30 12:03 ` Lars Ingebrigtsen
2022-03-31 9:47 ` Michael Albinus
2022-03-31 11:41 ` Lars Ingebrigtsen
2022-03-31 18:09 ` Phil Sainty
2022-04-01 7:06 ` Michael Albinus
2022-04-02 13:02 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mth7bqua.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=54606@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.