From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: PGTK-related misconceptions Date: Wed, 20 Apr 2022 12:05:05 +0800 Message-ID: <87mtggcscu.fsf@yahoo.com> References: <87y202f4dq.fsf@treypeacock.com> <87o80xhor2.fsf@yahoo.com> <877d7lrbta.fsf@treypeacock.com> <87mtghg0j6.fsf@yahoo.com> <87pmlcad91.fsf@treypeacock.com> <875yn4eg0w.fsf@yahoo.com> <87mtgga3h6.fsf@treypeacock.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11820"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Morgan Smith , emacs-devel@gnu.org To: Trey Peacock Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 20 06:06:33 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nh1bt-0002wE-A0 for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Apr 2022 06:06:33 +0200 Original-Received: from localhost ([::1]:48266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nh1br-0007rc-VG for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Apr 2022 00:06:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nh1af-00077p-JO for emacs-devel@gnu.org; Wed, 20 Apr 2022 00:05:17 -0400 Original-Received: from sonic307-10.consmr.mail.ne1.yahoo.com ([66.163.190.33]:46305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nh1ad-0005SO-Ew for emacs-devel@gnu.org; Wed, 20 Apr 2022 00:05:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1650427512; bh=sFY3QPBf4UvDb6n9GoI+g8FIpQ0+TX9GhUgfXnHv8Zg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=lwKoedE5HvttiPyPanQv1mwc/GIDdGy+mCEgi95irT/IMy8eCG39xssPqixMSvlp6e0Vs6aQ9tf0VvX4mN4+Tusrig2t2JkxJ48B9mqDnoBdP95o6EaapQsnf4hV024QBys314+8RjTZdKRNldta0C1c4/v8/s0usMkkh9sSB4P0ZtcfJjoDB4lRw5nntM37b0/VwjTpMoOmpYxQ89Efwra69sdN87rczVwba4SS6BZrGFg59QPF6Pe8ktj8HrXQuavyFr3Jtm6hOh5kY/QbxyBHhzO0RAW14sHhj9VWKHzGgFhUQ6NfyYwNME20AlSfDmA1JooxNh9aC8Q7W/5D6w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1650427512; bh=zXsUZnR/89nh04h7E5+CU4IwKH+ER6ULrpfvsOORr9a=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Rcs6cIQCLqhaGcF5+Q6M+RVKhe9aybiUNqBCubzkPofum4RYhqlBckhPNbN6bwnUO39LLYurtH9yz0ySY6AkvPbgTERqtJ8xTLR2Hl48XaXAIIWoFQESQMx6uTTiYI4HKkmbzYMsF+cIB2FwPN5l38S8bxpuKUO2w19YYwcTXLKJGHyGXjQwkgjMIq6nbcSd45eyfcmX7J9RRIC1xqS19nhHvAhlJmtY1wk7WxIuMiFA9kb+mZ4VP9j+xvTlLtMYDn06fzyFtT+pzwdzAaGPo79uJxIGUM9TDbfubNkEUo7QM+SlU5Hmq4VLvEVP4knb8hPNhZvreOGB/kZh4X9Wnw== X-YMail-OSG: YHjygbIVM1mHo_ZoCNF_AaH7fS366mPJOjYCIWMKDyaokfpJOOY8Adk1BXiabO0 tW0KDOTySI__mI1LuvHcjXLkB91Dn8evgq7kirJbJAPrvsgSGmcMNxQVKHS_22VPn5zRlvQBIRCL 19.IS3g2JVe4KkzKJfiFjwMBzKcCktDqpYxDgMgAgjE5c6HRRiHBQGRfuinBtcsQnauTeDDe3J0C sQdRhYtPl8C0eUkiojns_qrGC6TFK6NcaI.S2R3l6xKSGjHhL9.eWwKPsBbAUeYejS_OlVQq0f_b ok7qYjBT852ETseycAHR.5u_3a7oxKkXdDBgALFjXHxW14nkvPE0CCrtLB0Lbu5cQlic4pzPzu11 TGlIJRvvqiV5p5CCi4q4WrYoRRD6NJtsthzknMFK9cK8azLTlYeBwxBe_JJCCoe4y5M3Alx_gtBc QS_CTYI.Yj01iyO8jWmJZXZkhGaUasI0mfmW_oabxCrOLQOeEc6htbzRhy0lpisqD.CjlI3nZsRd jJIJMASXIUzRHhosOo_roaUfgFS5msB7_TNkTMd7LuAuZN5p5wCPblvjGlHXRjDqqP.PR1FIzAPG cKq3TCPock2AsdqyHBkqR2GOtDkNjL6P7z.pFQgaWqsoBciFDa5XZC4plKU.YPO5s3AfskpqymIt qMWN2Kp3gI2flCKYvigr_RY.2Rm.RHebNjJI.95EjETrMm5ZJgPM2X0uvujnQBJa1wHjd5epdvYd KNzyMV2E7t3knFNWvma9HGB.3IQuf0St1hDyd0KcG6zokS2c1SYXi86vlank.ngMmZomtU4GJShg Jobgi2dwd5Yk055pb04r7lT7KaaADix4LeDzt5K1D4 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Wed, 20 Apr 2022 04:05:12 +0000 Original-Received: by hermes--canary-production-sg3-6589f79784-rwljk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0cfb72ee0305a062f5e56b17c43a8a1c; Wed, 20 Apr 2022 04:05:09 +0000 (UTC) In-Reply-To: <87mtgga3h6.fsf@treypeacock.com> (Trey Peacock's message of "Wed, 20 Apr 2022 02:33:14 +0000") X-Mailer: WebService/1.1.20048 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.33; envelope-from=luangruo@yahoo.com; helo=sonic307-10.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288689 Archived-At: Trey Peacock writes: >> See https://docs.gtk.org/gdk3/flags.ModifierType.html, which says: >> >> Since 2.10, GDK recognizes which of the Meta, Super or Hyper keys are >> mapped to Mod2 - Mod5, and indicates this by setting GDK_SUPER_MASK, >> GDK_HYPER_MASK or GDK_META_MASK in the state field of key events. > > The capability to do something is not the same as a requirement. It's the documented behavior of GDK, and Emacs holds GDK to its documentation. Nowhere does the documentation say this is a "capability", "recognizes" is in the third-person present tense, which makes it a requirement. > I would be happy to help. Granted, this is only my second interaction on > the mailing list, but I do want to contribute how I can. Great, one step forward would be to bring up the issue with either the GTK or Wayland compositor developers. Since you've already talked with the latter, and they say it's not their problem, please contact the former. > It is not GDK that is responsible for this. Further, since this is not > required, I don't think its proper to deem it a bug. It is, as specified in its documentation. > Your change seems to have removed a fallback in case there were no > virtual modifiers and reverses the previous logic: As you can see by the name of the function, it was directly ported over from X (the current version is in xterm.c), and is yet another example of the PGTK port translating X Windows code to GDK verbatim, duplicating what GDK is supposed to do itself. I will not change Emacs because the GTK developers, yet again, forgot to follow their own documentation when implementing some feature. It just makes Emacs code bloated, hard-to-follow and liable to break at the slightest whim of the GTK developers, who then respond that we're not using GTK "properly", because we try to work around their problems.