From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56372: 29.0.50; [PATCH] Avoid BadMatch X11 error Date: Mon, 04 Jul 2022 18:58:43 +0800 Message-ID: <87mtdp9mak.fsf@yahoo.com> References: <87czemtfv0.fsf@dick> <87r131fpmm.fsf@dick> <87r1319ojr.fsf@yahoo.com> <871qv19o44.fsf@gnus.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23666"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 56372@debbugs.gnu.org, dick To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 04 13:02:53 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8Jqv-0005zN-Oq for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jul 2022 13:02:53 +0200 Original-Received: from localhost ([::1]:35818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8Jqu-0001Wg-FK for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jul 2022 07:02:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8JoB-00086y-1f for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 07:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52363) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8JoA-0001np-Na for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 07:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o8JoA-0001U6-Kq for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 07:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2022 11:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56372 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo Original-Received: via spool by 56372-submit@debbugs.gnu.org id=B56372.16569323435594 (code B ref 56372); Mon, 04 Jul 2022 11:00:02 +0000 Original-Received: (at 56372) by debbugs.gnu.org; 4 Jul 2022 10:59:03 +0000 Original-Received: from localhost ([127.0.0.1]:46260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8JnC-0001SA-RJ for submit@debbugs.gnu.org; Mon, 04 Jul 2022 06:59:03 -0400 Original-Received: from sonic310-23.consmr.mail.ne1.yahoo.com ([66.163.186.204]:46404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8JnA-0001RG-LG for 56372@debbugs.gnu.org; Mon, 04 Jul 2022 06:59:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1656932334; bh=/+Uot+aGdcrNYalmHE8BsoBqwJbOAhlkHd3zpCryBbM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Jfi24cH4B8jyYGJ5EIDrtwtRU0+EOZdreNx2QNlOO0+o123ko8TK8R86NrThatOcjATP9J7pHhboQwkEalHQ7/ypxgkPEufB97K8DBkqqruf421u63lIlnWWRqOQ2s/MI2N/UBExdHesaWN1c6Bh/eI2nYvA/k2ZIowwgquibQ4efuNNbr+ypRq9yEAGhHQeOUQVWiziLIDelwZadSFAIJHYCo4g27vvjtS1kto5kJeTfOG63Ui2iHZeUwsy0nGfI8OT43h3wmAIx+FlMyBIvd6L5vPLDCnLB/uPWPePpJlT2XrLj3QUOgTk52fjwkKN354LrfpiiChvx5gmBwrg6w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1656932334; bh=BEE6Q+sMP+XnMH4kVNQQhUKSl2NUgf5oKr6Z/rPe/ph=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=gjetJ6YVZWavCCGnfXylS8gSBS8vU1WNpjBWgYYQx3Qhe/bnXrH1SU3xaDnOznIXm2lNQRvSs9lPM+LkdmBbVqA3JrGa/JEjZr3shHSvqHXuH5j4rxh+Jt0kdrEXx9z44hAC97FyGxIrkplr1hRlAYlstKtYkqJZvezRO0CCA8aw+JolFiD152XCSRAaKtNo0Q7UaflFWB1Nzth/6WGJG/+a8cPKGhS27wYUp/XTfqdUYcsVd7CBYUyNiko5mNjL2bKP0Qe9uIxMMSwYcS6be7L9r4v5b06RT8qJFIUdVqH7Yqbj0eSNhoEDWzHE0y3RCGDojb1kNQnIQxo3zanyQw== X-YMail-OSG: Y8CJY8QVM1kc49gfJeCsfmGU_8NWeMsdorEfhmJa.dPQ1JZ59HtoUfmZotfaGp8 ieavZZw1ywb5c1Ihg94fGqQdEccrdRMee9yMVZqXC92RXmS1WE86JgRfb6ToLzeoWMxADGBjsd0I pGlspdvBQ_3lhtpbFeJN18jpVnQh.bNwsAF8eABaGEvrbTYbReSgCrvGXuqMG7FJstz5IZb7u2XJ O9PxNBiGVTcgEoHXX1HokrzHKSRAgIbq3cTKIDRzj_8O.G_K5RJo66u.b7iWDQnsm0bgOtb.mEPo plubSfPH_sK2Sa5CR_2A5JQ6mAngN4ft_HJftm6d1SYopZTdOi_t0lBLRwfhTdNp_GGUkBGeHmYO ypay6Qy4ly2Skmwk2XkS2sIH40hdCPybkv0oxT9pQ7Ba12U42J8xmLCH3MDsI1nt4nhrfMHptel2 w0ir6f9u5O.Xnn.Cjo.6SMnIftRJatArLBbyEtRNRiJ1g3WtG3Ia1MFKQqrDP2aXgtrmJmOOdL3h gRKLufMAI.6Nx1_.0NRGUElNajpdt1S5zsKw1WNxuAbQ3EXDNKvFQOWEAAP5Qm74pSqEfim8POxY JNazjevIXlsQG6sQQNkQKniKhlxc9Wa6q2ENPhGUEZomYnT1TWhIcqsNl.Bzt4ZdK7wPHw.75EkE ceHd0zaXIyUCbz1EIgHo1H950.Nm5jVZyBnvDdU1uW0WhVo7HqLjyZDeLuSZhkvT_4Mxk8vngNVT EjGotwrUe5nwao3jknllo9JIPzWmPGKLiLBQdXzn05WZmAxCshVXJH4YJpN6BeWGJ9ZwFbnsr0MO LP6Jr.1pO6lbDW5rvxsWF5h9u8TGb4vNDBNt0qGWGl X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Mon, 4 Jul 2022 10:58:54 +0000 Original-Received: by hermes--canary-production-sg3-67975bbd4b-27vvd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b6e0ddb96ae5c29c3e627d2ce83372fc; Mon, 04 Jul 2022 10:58:48 +0000 (UTC) In-Reply-To: <871qv19o44.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 04 Jul 2022 12:19:23 +0200") X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236049 Archived-At: Lars Ingebrigtsen writes: > Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text > editors" writes: > >> That piece of code is already inside "if (dpyinfo)" > > Indeed. And aren't we testing for dpyinfo twice already in that code? > > Unless I'm misreading, it's: > > /* If DPYINFO is null, this means we didn't open the display in the > first place, so don't try to close it. */ > if (dpyinfo) > { > ... no code here that sets dpyinfo ... > [...] > if (dpyinfo->terminal == terminal_list > && !terminal_list->next_terminal) > { > fprintf (stderr, "%s\n", error_msg); > > if (!ioerror && dpyinfo) > { > > That && dpyinfo seems redundant? Yes, sorry. That's left over from another piece of code.