all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Brennan Vincent <brennan@umanwizard.com>
Cc: 56430@debbugs.gnu.org
Subject: bug#56430: [PATCH] fix broken `imenu--create-keymap` when an item is nil
Date: Thu, 07 Jul 2022 10:59:57 +0200	[thread overview]
Message-ID: <87mtdlguwi.fsf@gnus.org> (raw)
In-Reply-To: <ddd41ef0-8b6a-5438-8d21-2a758ebe6c1c@umanwizard.com> (Brennan Vincent's message of "Wed, 6 Jul 2022 15:45:45 -0400")

Brennan Vincent <brennan@umanwizard.com> writes:

> -                `(,(intern (car item)) ,(car item)
> +                `(,(and (car item) (intern (car item))) ,(car item)
>                    ,@(cond
>                       ((imenu--subalist-p item)
>                        (imenu--create-keymap (car item) (cdr item) cmd))

In what cases is (car item) nil here?  Isn't that a bug in the caller?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-07-07  8:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06 19:45 bug#56430: [PATCH] fix broken `imenu--create-keymap` when an item is nil Brennan Vincent
2022-07-07  8:59 ` Lars Ingebrigtsen [this message]
2022-07-07 14:26   ` Brennan Vincent
2022-07-07 18:02     ` Lars Ingebrigtsen
2022-07-07 18:18       ` Brennan Vincent
2022-07-07 18:22         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtdlguwi.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=56430@debbugs.gnu.org \
    --cc=brennan@umanwizard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.