From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#56554: [PATCH] * lisp/image.el (put-image): Fix typo. Date: Thu, 14 Jul 2022 19:39:15 +0530 Message-ID: <87mtdbrdkk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38849"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 56554@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 14 16:10:46 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBzYE-0009xN-Ks for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Jul 2022 16:10:46 +0200 Original-Received: from localhost ([::1]:47962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBzYD-0002Pm-A8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Jul 2022 10:10:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBzXW-0002LU-I0 for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 10:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40757) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oBzXW-0002kV-7d for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 10:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oBzXV-000319-SL for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 10:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jul 2022 14:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56554 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.165780777611558 (code B ref -1); Thu, 14 Jul 2022 14:10:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Jul 2022 14:09:36 +0000 Original-Received: from localhost ([127.0.0.1]:38515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBzX5-00030L-RO for submit@debbugs.gnu.org; Thu, 14 Jul 2022 10:09:36 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:34682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBzX1-00030C-O3 for submit@debbugs.gnu.org; Thu, 14 Jul 2022 10:09:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBzWt-0001zF-RA for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 10:09:27 -0400 Original-Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:42792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oBzWq-0002h6-Qr for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 10:09:23 -0400 Original-Received: by mail-pl1-x644.google.com with SMTP id 5so512313plk.9 for ; Thu, 14 Jul 2022 07:09:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:user-agent:mime-version; bh=nxQaL6o25mjXJBKLxlsHWfp2umUrvDS6uf0r0vNhuug=; b=O9ltd03E8krVQKM3TkqkeWDN0Ztny1oSP/qJaMs7bzAZskGqmZ4cPpjg3TCphpKM1k q1JwWhOfpV3rUtlggcecsCymyyjFjidcjzelqFTJncXHkcl+U5qx6HDn5ITYCs0gWpDu E+i4kXB1sNE/XVwRkWvQ5uYllH8lArg2ALEX+5Jqyqx04/gquLqxmC1Tz/riHmSWesLC psqSSStaZVlBNYFaXLd0IwrDKm16jXDk4ChwwYZ0H9/Ba8dqitN66Fn5pqMgArTdL643 1Ki5M7YyXAdAv5XSpFtVFeTFX1pB+urcx7DCRJI1O/X5VLwcAq86wAWyWZPaFm+ONyGT RH4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=nxQaL6o25mjXJBKLxlsHWfp2umUrvDS6uf0r0vNhuug=; b=HWCdB+p239hXxAwrdpnn4PAIg7gPZksQBkdiJOTeZJKV3/wU/OSsGzef78avlDEUDL NCAZQKAjNL2E07pouPSd1I7ac2DAYyrSRBhskYTkFGm1JXue68L0p2PoBPP+CPCNcMVZ 9zR+HjC4E8YGBSetTwI85Zv6zXeeAP5I/KO9kQd9fKpYqyUSlZS3fQZpB/0guP2ILM+x aUrvseG7r7KwBaMEdE2psI4I2vXZO6uHVc+cV004WFBEgofG5OyXWlettFbwVjb9A/Au JCDQEiCtSkWCe38VIRSf6LwGHuRs2Q/Df567eA62ZKt3jVfqgA77XENMrzeFoerIF9D/ MKwA== X-Gm-Message-State: AJIora+v7ZVUcjN033AVW5V8cyTfEYA+JH6PlTdu4rILZWnkMjc6i+NU lsetLsg0jjBTOVBLra9Bn/6Ai21jDT0= X-Google-Smtp-Source: AGRyM1uxT7SmhDR0nSRmdMo9qD8zbjBmJQvnNbUkZT5HFdwwGhuGSiPe3XhmQZHp5TW5nebJML1SWA== X-Received: by 2002:a17:902:988b:b0:16b:fae3:fcd5 with SMTP id s11-20020a170902988b00b0016bfae3fcd5mr9047548plp.109.1657807758916; Thu, 14 Jul 2022 07:09:18 -0700 (PDT) Original-Received: from localhost ([49.205.81.141]) by smtp.gmail.com with ESMTPSA id u16-20020a170903125000b001690d398401sm1560333plh.88.2022.07.14.07.09.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jul 2022 07:09:17 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::644; envelope-from=visuweshm@gmail.com; helo=mail-pl1-x644.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236994 Archived-At: --=-=-= Content-Type: text/plain Tags: patch This fixes a typo in put-image. BTW, even with this patch applied, I still can't access the keys in image-map: I think it is because one cannot place the point on the image? Is this intended? If yes, can we change mm-inline-image to use insert-image instead (it currently uses put-image)? Thanks. In GNU Emacs 29.0.50 (build 11, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars) of 2022-07-14 built on astatine Repository revision: d37ba6f259b972aa44c66ecb76210e03a3084183 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101003 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure --with-sound=alsa --with-x-toolkit=lucid --with-json --without-xaw3d --without-gconf --without-libsystemd --without-cairo' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-lisp-image.el-put-image-Fix-typo.patch >From 07de01f5f9096e9a2e57d93ccd9edd76c7467e11 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Thu, 14 Jul 2022 19:25:19 +0530 Subject: [PATCH] * lisp/image.el (put-image): Fix typo. --- lisp/image.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/image.el b/lisp/image.el index bdaaec608e..cb5ef4e8d1 100644 --- a/lisp/image.el +++ b/lisp/image.el @@ -613,7 +613,7 @@ put-image (put-text-property 0 (length string) 'display prop string) (overlay-put overlay 'put-image t) (overlay-put overlay 'before-string string) - (overlay-put overlay 'map image-map) + (overlay-put overlay 'keymap image-map) overlay))) -- 2.35.1 --=-=-=--