* bug#56554: [PATCH] * lisp/image.el (put-image): Fix typo.
@ 2022-07-14 14:09 Visuwesh
2022-07-14 17:34 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Visuwesh @ 2022-07-14 14:09 UTC (permalink / raw
To: 56554
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
Tags: patch
This fixes a typo in put-image.
BTW, even with this patch applied, I still can't access the keys in
image-map: I think it is because one cannot place the point on the
image? Is this intended? If yes, can we change mm-inline-image to use
insert-image instead (it currently uses put-image)? Thanks.
In GNU Emacs 29.0.50 (build 11, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars)
of 2022-07-14 built on astatine
Repository revision: d37ba6f259b972aa44c66ecb76210e03a3084183
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Debian GNU/Linux bookworm/sid
Configured using:
'configure --with-sound=alsa --with-x-toolkit=lucid --with-json
--without-xaw3d --without-gconf --without-libsystemd --without-cairo'
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-image.el-put-image-Fix-typo.patch --]
[-- Type: text/patch, Size: 710 bytes --]
From 07de01f5f9096e9a2e57d93ccd9edd76c7467e11 Mon Sep 17 00:00:00 2001
From: Visuwesh <visuweshm@gmail.com>
Date: Thu, 14 Jul 2022 19:25:19 +0530
Subject: [PATCH] * lisp/image.el (put-image): Fix typo.
---
lisp/image.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/image.el b/lisp/image.el
index bdaaec608e..cb5ef4e8d1 100644
--- a/lisp/image.el
+++ b/lisp/image.el
@@ -613,7 +613,7 @@ put-image
(put-text-property 0 (length string) 'display prop string)
(overlay-put overlay 'put-image t)
(overlay-put overlay 'before-string string)
- (overlay-put overlay 'map image-map)
+ (overlay-put overlay 'keymap image-map)
overlay)))
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#56554: [PATCH] * lisp/image.el (put-image): Fix typo.
2022-07-14 14:09 bug#56554: [PATCH] * lisp/image.el (put-image): Fix typo Visuwesh
@ 2022-07-14 17:34 ` Lars Ingebrigtsen
2022-07-14 17:40 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-14 17:34 UTC (permalink / raw
To: Visuwesh; +Cc: 56554
Visuwesh <visuweshm@gmail.com> writes:
> This fixes a typo in put-image.
Thanks; pushed to Emacs 29.
> BTW, even with this patch applied, I still can't access the keys in
> image-map: I think it is because one cannot place the point on the
> image? Is this intended? If yes, can we change mm-inline-image to use
> insert-image instead (it currently uses put-image)? Thanks.
Yup; makes sense. I'll get fixing...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#56554: [PATCH] * lisp/image.el (put-image): Fix typo.
2022-07-14 17:34 ` Lars Ingebrigtsen
@ 2022-07-14 17:40 ` Lars Ingebrigtsen
2022-07-14 17:43 ` Visuwesh
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2022-07-14 17:40 UTC (permalink / raw
To: Visuwesh; +Cc: 56554
Lars Ingebrigtsen <larsi@gnus.org> writes:
>> BTW, even with this patch applied, I still can't access the keys in
>> image-map: I think it is because one cannot place the point on the
>> image? Is this intended? If yes, can we change mm-inline-image to use
>> insert-image instead (it currently uses put-image)? Thanks.
>
> Yup; makes sense. I'll get fixing...
Now done.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#56554: [PATCH] * lisp/image.el (put-image): Fix typo.
2022-07-14 17:40 ` Lars Ingebrigtsen
@ 2022-07-14 17:43 ` Visuwesh
0 siblings, 0 replies; 4+ messages in thread
From: Visuwesh @ 2022-07-14 17:43 UTC (permalink / raw
To: Lars Ingebrigtsen; +Cc: 56554
[வியாழன் ஜூலை 14, 2022] Lars Ingebrigtsen wrote:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>>> BTW, even with this patch applied, I still can't access the keys in
>>> image-map: I think it is because one cannot place the point on the
>>> image? Is this intended? If yes, can we change mm-inline-image to use
>>> insert-image instead (it currently uses put-image)? Thanks.
>>
>> Yup; makes sense. I'll get fixing...
>
> Now done.
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-14 17:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-14 14:09 bug#56554: [PATCH] * lisp/image.el (put-image): Fix typo Visuwesh
2022-07-14 17:34 ` Lars Ingebrigtsen
2022-07-14 17:40 ` Lars Ingebrigtsen
2022-07-14 17:43 ` Visuwesh
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.