From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#56704: 28.1.90; shr: The DOM is lost in the rendered result Date: Fri, 22 Jul 2022 17:16:40 +0200 Message-ID: <87mtd1qisn.fsf@cassou.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17223"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Magne Ingebrigtsen To: 56704@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 22 17:19:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEuR6-0004JY-OB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Jul 2022 17:19:28 +0200 Original-Received: from localhost ([::1]:34984 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEuR5-0003sE-Me for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Jul 2022 11:19:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEuPi-0002Vn-6M for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2022 11:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52430) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oEuPh-0003ok-U0 for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2022 11:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oEuPh-0000md-PR for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2022 11:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jul 2022 15:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56704 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16585030222919 (code B ref -1); Fri, 22 Jul 2022 15:18:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Jul 2022 15:17:02 +0000 Original-Received: from localhost ([127.0.0.1]:42177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEuOk-0000l0-7n for submit@debbugs.gnu.org; Fri, 22 Jul 2022 11:17:02 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:47362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEuOf-0000kW-MB for submit@debbugs.gnu.org; Fri, 22 Jul 2022 11:17:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEuOf-0001eu-Fh for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2022 11:16:57 -0400 Original-Received: from mail.choca.pics ([80.67.172.235]:38484) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEuOa-0003Zx-Mm for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2022 11:16:57 -0400 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 2530418192DD4; Fri, 22 Jul 2022 17:16:42 +0200 (CEST) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id Lff03Tfdc7fO; Fri, 22 Jul 2022 17:16:41 +0200 (CEST) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 7734618192DD5; Fri, 22 Jul 2022 17:16:41 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id cUzBQMnPyYWB; Fri, 22 Jul 2022 17:16:41 +0200 (CEST) Original-Received: from localhost (240-68-190-109.dsl.ovh.fr [109.190.68.240]) by mail.choca.pics (Postfix) with ESMTPSA id 24F2218192DD4; Fri, 22 Jul 2022 17:16:41 +0200 (CEST) Received-SPF: pass client-ip=80.67.172.235; envelope-from=damien@cassou.me; helo=mail.choca.pics X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237638 Archived-At: Hi, SHR doesn't link the text being inserted in the buffer and DOM node being rendered. This means it is not possible to implement some use cases, e.g., - inspect/copy the DOM node rendered at point; - share/bookmark a link to a particular section of a page (which requires knowing the id attribute of the enclosing DOM node). I fixed this by changing shr-generic from: (defsubst shr-generic (dom) (dolist (sub (dom-children dom)) (if (stringp sub) (shr-insert sub) (shr-descend sub)))) to (defsubst shr-generic (dom) (let ((start (point))) (dolist (sub (dom-children dom)) (if (stringp sub) (shr-insert sub) (shr-descend sub))) (unless (eq start (point-max)) (put-text-property start (1+ start) 'shr-dom dom)))) This seems to work great. Is this change desirable? Do you want a patch? -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill