[BUG] org-insert-heading-respect-content doesn't always insert TODO heading [9.5.4 (release_9.5.4-17-g6e991f @ /usr/local/Cellar/emacs-plus@29/29.0.50/share/emacs/29.0.50/lisp/org/)]

[BUG] org-insert-heading-respect-content doesn't always insert TODO heading [9.5.4 (release_9.5.4-17-g6e991f @ /usr/local/Cellar/emacs-plus@29/29.0.50/share/emacs/29.0.50/lisp/org/)]

[Roman Rudakov]

Hello!

Steps to reproduce:
1. Create an org heading and set state to something but TODO or DONE
(for example PROGRESS).
2. Call the function org-insert-todo-heading-respect-content

Expected result:

New heading with TODO state in inserted

Actual result:

New heading is inserted with the same state as previous heading.

I noticed that internally this function calls org-insert-todo-heading
and pass arguments in a wrong order:

Actual function call:

(org-insert-todo-heading force-state '(4))

Should be:

(org-insert-todo-heading '(4)) force-state)


Emacs  : GNU Emacs 29.0.50 (build 1, x86_64-apple-darwin21.6.0, NS
appkit-2113.60 Version 12.5 (Build 21G72))
 of 2022-08-14
Package: Org mode version 9.5.4 (release_9.5.4-17-g6e991f @
/usr/local/Cellar/emacs-plus@29/29.0.50/share/emacs/29.0.50/lisp/org/)

Re: [BUG] org-insert-heading-respect-content doesn't always insert TODO heading [9.5.4 (release_9.5.4-17-g6e991f @ /usr/local/Cellar/emacs-plus@29/29.0.50/share/emacs/29.0.50/lisp/org/)]

[Ihor Radchenko]

Roman Rudakov <rrudakov@pm.me> writes:

> Steps to reproduce:
> 1. Create an org heading and set state to something but TODO or DONE
> (for example PROGRESS).
> 2. Call the function org-insert-todo-heading-respect-content
> ...
> I noticed that internally this function calls org-insert-todo-heading
> and pass arguments in a wrong order:
>
> Actual function call:
>
> (org-insert-todo-heading force-state '(4))
>
> Should be:
>
> (org-insert-todo-heading '(4)) force-state)

Thanks for reporting and pinpointing the source of the bug!
Fixed on main via a1af06d64.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a1af06d643d662f8c04e7c59d10efc45108a9528

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92