all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Roman Rudakov <rrudakov@pm.me>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-insert-heading-respect-content doesn't always insert TODO heading [9.5.4 (release_9.5.4-17-g6e991f @ /usr/local/Cellar/emacs-plus@29/29.0.50/share/emacs/29.0.50/lisp/org/)]
Date: Sat, 20 Aug 2022 14:04:26 +0800	[thread overview]
Message-ID: <87mtbzo3h1.fsf@localhost> (raw)
In-Reply-To: <m1a683p42k.fsf@rrudakov-mbp.lan>

Roman Rudakov <rrudakov@pm.me> writes:

> Steps to reproduce:
> 1. Create an org heading and set state to something but TODO or DONE
> (for example PROGRESS).
> 2. Call the function org-insert-todo-heading-respect-content
> ...
> I noticed that internally this function calls org-insert-todo-heading
> and pass arguments in a wrong order:
>
> Actual function call:
>
> (org-insert-todo-heading force-state '(4))
>
> Should be:
>
> (org-insert-todo-heading '(4)) force-state)

Thanks for reporting and pinpointing the source of the bug!
Fixed on main via a1af06d64.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a1af06d643d662f8c04e7c59d10efc45108a9528

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92


      reply	other threads:[~2022-08-20  6:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 10:17 [BUG] org-insert-heading-respect-content doesn't always insert TODO heading [9.5.4 (release_9.5.4-17-g6e991f @ /usr/local/Cellar/emacs-plus@29/29.0.50/share/emacs/29.0.50/lisp/org/)] Roman Rudakov
2022-08-20  6:04 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtbzo3h1.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=rrudakov@pm.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.