From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/ef-themes 71fb847eca 2/2: Add FIXME about simplifying ef-themes-collection Date: Sat, 17 Sep 2022 13:04:38 +0000 Message-ID: <87mtaym9sp.fsf@posteo.net> References: <166335465493.17197.7832233071746944297@vcs2.savannah.gnu.org> <20220916185735.5AAFBC00874@vcs2.savannah.gnu.org> <87czbu5lnj.fsf@posteo.net> <87a66yw5d9.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31411"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Protesilaos Stavrou Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 17 15:07:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZXXZ-0007xb-41 for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Sep 2022 15:07:25 +0200 Original-Received: from localhost ([::1]:39006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZXXX-0004R6-DF for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Sep 2022 09:07:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZXUz-0003On-Ov for emacs-devel@gnu.org; Sat, 17 Sep 2022 09:04:45 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:41297) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZXUx-0006Sr-QP for emacs-devel@gnu.org; Sat, 17 Sep 2022 09:04:45 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3F9EA240026 for ; Sat, 17 Sep 2022 15:04:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1663419880; bh=A9qaNxa73rfQq0jZj5Aktn5D0MC3I0CRfI+cd83ivlI=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=T7F4ZBy+ub9qzkXLfWy0rfKTOzs8loiWPajj33pv9fzsj35K0XoXCbp2zDGajGJXX z8EIaplorQ1e66SzyFNwkh9f8Kk4tXIquaZaUZTouh7LtjNS2t7JODgk1qMq/KBJv7 4e9ZGkQ1HoEK0/FSDJSgVN5Fqmi+QGQbT7s7T8AbN+Jq89pgmRm+JpZsx2Udh384HC bCDlf+JdqfJ7/jaf7rpAw4AaxsAnIi0iNIY6nYp9CM7kVUCtT4WfbZI2050fLDUNiu xZUSYyQChbG9DXIPUWuCk2RFxnBzuwrkQx59zO9QCkGuWEv4xwywpwip2wgJpsqIe5 z/GL2crknzwRw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MVB3q32pzz9rxW; Sat, 17 Sep 2022 15:04:39 +0200 (CEST) In-Reply-To: <87a66yw5d9.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Sat, 17 Sep 2022 15:30:10 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295525 Archived-At: Protesilaos Stavrou writes: >> From: Philip Kaludercic >> Date: Sat, 17 Sep 2022 10:40:32 +0000 > >> [... 21 lines elided] > >>> +;; FIXME 2022-09-16: Maybe the `ef-themes-collection' should just >>> +;; combine the `ef-themes-light-themes' and `ef-themes-dark-themes'? >>> +;; This duplication seems unnecessary. >>> (defconst ef-themes-collection >>> '(ef-autumn >>> ef-dark >> >> Is there any reason you couldn't just replace the definition with >> >> (seq-union ef-themes-light-themes ef-themes-dark-themes) >> >> ? > > You mean to include that in the relevant functions and remove the > 'ef-themes-collection' altogether? I was thinking of replacing the '(ef-autumn ef-dark with the `seq-union' call from above. > I was thinking that having a > standalone variable is easier for documentation purposes. Same for > 'ef-themes-{dark,light}-themes'. > > Though yes, your code does what I want.