From: Lars Ingebrigtsen <larsi@gnus.org>
To: miha@kamnitnik.top
Cc: Eli Zaretskii <eliz@gnu.org>,
58518@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#58518: 29.0.50; [PATCH] Turning off compilation-minor-mode removes fontification of other modes
Date: Sat, 15 Oct 2022 12:25:32 +0200 [thread overview]
Message-ID: <87mt9x4c4j.fsf@gnus.org> (raw)
In-Reply-To: <87pmeue8s3.fsf@miha-pc> (miha@kamnitnik.top's message of "Fri, 14 Oct 2022 17:15:24 +0200")
miha@kamnitnik.top writes:
> The attached patch makes them return to the face they had after step 2,
> as specified by the grep command.
[...]
> - `(font-lock-face ,(if leave
> - compilation-leave-directory-face
> - compilation-enter-directory-face)
> + `(compilation-face ,(if leave
> + compilation-leave-directory-face
[...]
> + (let ((alist (copy-alist char-property-alias-alist)))
> + (cl-pushnew 'compilation-face (alist-get 'face alist))
Hm, it's an interesting approach -- we don't use this trick elsewhere in
other mode (I mean, except for `font-lock-face'), but this seems like a
good solution.
But since it's so unusual, I wonder whether there's any reason we don't
use this more in general. Are there performance impacts, for instance?
(I don't think so, since it's a buffer-local variable.) But I've added
Stefan and Eli to the CCs; perhaps they have comments.
next prev parent reply other threads:[~2022-10-15 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 15:15 bug#58518: 29.0.50; [PATCH] Turning off compilation-minor-mode removes fontification of other modes miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-15 10:25 ` Lars Ingebrigtsen [this message]
2022-10-15 14:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-16 8:24 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt9x4c4j.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=58518@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=miha@kamnitnik.top \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.